From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758570Ab3BZIHg (ORCPT ); Tue, 26 Feb 2013 03:07:36 -0500 Received: from smtp-vbr6.xs4all.nl ([194.109.24.26]:2497 "EHLO smtp-vbr6.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163Ab3BZIHe (ORCPT ); Tue, 26 Feb 2013 03:07:34 -0500 From: Hans Verkuil To: Andrey Smirnov Subject: Re: [PATCH v5 6/8] v4l2: Add documentation for the FM RX controls Date: Tue, 26 Feb 2013 09:06:32 +0100 User-Agent: KMail/1.13.7 (Linux/3.8.0-rc3-tschai; KDE/4.8.4; x86_64; ; ) Cc: mchehab@redhat.com, sameo@linux.intel.com, perex@perex.cz, tiwai@suse.de, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <1361860734-21666-1-git-send-email-andrew.smirnov@gmail.com> <1361860734-21666-7-git-send-email-andrew.smirnov@gmail.com> In-Reply-To: <1361860734-21666-7-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201302260906.32862.hverkuil@xs4all.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue February 26 2013 07:38:52 Andrey Smirnov wrote: > Add appropriate documentation for all the newly added standard > controls. Give credit to Manjunatha Halli. > Signed-off-by: Andrey Smirnov > --- > Documentation/DocBook/media/v4l/compat.xml | 3 + > Documentation/DocBook/media/v4l/controls.xml | 72 ++++++++++++++++++++ > .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 11 ++- > 3 files changed, 85 insertions(+), 1 deletion(-) > > diff --git a/Documentation/DocBook/media/v4l/compat.xml b/Documentation/DocBook/media/v4l/compat.xml > index 104a1a2..f418bc3 100644 > --- a/Documentation/DocBook/media/v4l/compat.xml > +++ b/Documentation/DocBook/media/v4l/compat.xml > @@ -2310,6 +2310,9 @@ more information. > > Added FM Modulator (FM TX) Extended Control Class: V4L2_CTRL_CLASS_FM_TX and their Control IDs. > > + > + Added FM Receiver (FM RX) Extended Control Class: V4L2_CTRL_CLASS_FM_RX and their Control IDs. > + > > Added Remote Controller chapter, describing the default Remote Controller mapping for media devices. > > diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > index 9e8f854..e8fe005 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -4687,4 +4687,76 @@ interface and may change in the future. > > > > + > +
> + FM Receiver Control Reference > + > + The FM Receiver (FM_RX) class includes controls for common features of > + FM Reception capable devices. > + > + > + FM_RX Control IDs > + > + > + > + > + > + > + > + > + > + > + ID > + Type > + Description > + > + > + > + > + > + V4L2_CID_FM_RX_CLASS  > + class > + The FM_RX class > +descriptor. Calling &VIDIOC-QUERYCTRL; for this control will return a > +description of this control class. > + > + > + V4L2_CID_RDS_RECEPTION  > + boolean > + Enables/disables RDS > + reception by the radio tuner > + > + > + V4L2_CID_TUNE_DEEMPHASIS  > + integer This is type 'enum v4l2_deemphasis', not integer. BTW, V4L2_CID_TUNE_PREEMPHASIS has the same mistake, can you update that entry as well to 'enum v4l2_preemphasis'? > + > + Configures the de-emphasis value for reception. > +A de-emphasis filter is applied to the broadcast to accentuate the high audio frequencies. > +Depending on the region, a time constant of either 50 or 75 useconds is used. The enum v4l2_emphasis enum v4l2_deemphasis > +defines possible values for de-emphasis. Here they are: > + > + > + > + > + V4L2_PREEMPHASIS_DISABLED  > + No de-emphasis is applied. > + > + > + V4L2_PREEMPHASIS_50_uS  > + A de-emphasis of 50 uS is used. > + > + > + V4L2_PREEMPHASIS_75_uS  > + A de-emphasis of 75 uS is used. For the three constants above: PRE -> DE > + > + > + > + > + > + > + > + > +
> + > +
> > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml b/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml > index 4e16112..b03a57b 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml > @@ -9,7 +9,7 @@ VIDIOC_TRY_EXT_CTRLS > VIDIOC_G_EXT_CTRLS > VIDIOC_S_EXT_CTRLS > VIDIOC_TRY_EXT_CTRLS > - Get or set the value of several controls, try control > + Get or set the value of several controls, try control Spurious whitespace change, just revert this to the original. > values > > > @@ -319,6 +319,15 @@ These controls are described in processing controls. These controls are described in linkend="image-process-controls" />. > > + > + > + V4L2_CTRL_CLASS_FM_RX > + 0xa10000 > + The class containing FM Receiver (FM RX) controls. > +These controls are described in + linkend="fm-rx-controls" />. > + > + > > > > Regards, Hans