From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Roland Dreier <roland@kernel.org>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] IB/mlx4: silence GCC warning
Date: Tue, 26 Feb 2013 09:57:04 +0200 [thread overview]
Message-ID: <201302260957.04585.jackm@dev.mellanox.co.il> (raw)
In-Reply-To: <CAL1RGDWt2cgcwec-iQ9f8-YvC8fO2AncGBfQ2VUgPi3W49bKxg@mail.gmail.com>
On Monday 25 February 2013 19:23, Roland Dreier wrote:
> On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier <roland@kernel.org> wrote:
> > I'm finally noticing that this is in the build_mlx_header() function,
> > which is pretty much a slow path. Certainly another compare isn't
> > going to change performance given all the other stuff we do there.
> >
> > Let me look at the patches that have gone by and see what the cleanest
> > way to handle this is.
>
> OK, after playing around a bit, I see that just initializing vlan
> doesn't really change the generated code (my gcc at least was already
> if effect setting vlan in the generated assembly code), so I'll just
> merge that.
>
> - R.
Thanks!
-Jack
prev parent reply other threads:[~2013-02-26 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:48 [PATCH] IB/lmx4: " Paul Bolle
2012-10-10 7:23 ` Jack Morgenstein
2012-10-29 9:50 ` Paul Bolle
2013-02-13 13:50 ` Bart Van Assche
2013-02-21 9:02 ` [PATCH v2] IB/mlx4: " Paul Bolle
2013-02-24 12:34 ` Jack Morgenstein
2013-02-25 16:54 ` Roland Dreier
2013-02-25 17:23 ` Roland Dreier
2013-02-26 7:57 ` Jack Morgenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302260957.04585.jackm@dev.mellanox.co.il \
--to=jackm@dev.mellanox.co.il \
--cc=bvanassche@acm.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®