From: Grant Likely <grant.likely@secretlab.ca>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Ryan Mallon <rmallon@gmail.com>,
linux-kernel@vger.kernel.org, gnurou@gmail.com,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio"
Date: Tue, 26 Feb 2013 17:51:54 +0000 [thread overview]
Message-ID: <20130226175154.D56DE3E167A@localhost> (raw)
In-Reply-To: <1360907177-6468-5-git-send-email-acourbot@nvidia.com>
On Fri, 15 Feb 2013 14:46:17 +0900, Alexandre Courbot <acourbot@nvidia.com> wrote:
> Their value being obtained by gpio_chip_hwgpio(), this better reflects
> their use.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
I'm not going to bother with this one. It is churn on things that are
only local variables with no functional change. I would be more inclined
if it was something globably visable, but locals are easy to grok.
g.
next prev parent reply other threads:[~2013-02-26 19:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 5:46 [PATCH v2 0/4] gpiolib: some fixup patches Alexandre Courbot
2013-02-15 5:46 ` [PATCH 1/4] gpiolib: check descriptors validity before use Alexandre Courbot
2013-02-26 17:48 ` Grant Likely
2013-02-15 5:46 ` [PATCH 2/4] gpiolib: use const parameters when possible Alexandre Courbot
2013-02-26 17:49 ` Grant Likely
2013-02-15 5:46 ` [PATCH 3/4] gpiolib: move comment to right function Alexandre Courbot
2013-02-15 5:46 ` [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio" Alexandre Courbot
2013-02-26 17:51 ` Grant Likely [this message]
2013-02-22 2:19 ` [PATCH v2 0/4] gpiolib: some fixup patches Alexandre Courbot
2013-02-26 17:53 ` Grant Likely
2013-02-27 1:22 ` Alexandre Courbot
2013-02-27 7:52 ` Grant Likely
2013-02-28 4:57 ` Alexandre Courbot
2013-02-28 6:21 ` Linus Walleij
2013-02-28 6:47 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2013-02-13 7:02 [PATCH " Alexandre Courbot
2013-02-13 7:03 ` [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio" Alexandre Courbot
2013-02-13 22:54 ` Ryan Mallon
2013-02-14 3:11 ` Alexandre Courbot
2013-02-13 7:03 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226175154.D56DE3E167A@localhost \
--to=grant.likely@secretlab.ca \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome