From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "'Tejun Heo'" <tj@kernel.org>,
"'Greg KH'" <greg@kroah.com>,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V2] rtc: add devm_rtc_device_{register,unregister}()
Date: Tue, 26 Feb 2013 14:33:04 -0800 [thread overview]
Message-ID: <20130226223304.GB20670@core.coreip.homeip.net> (raw)
In-Reply-To: <008c01ce13bf$8d2cd550$a7867ff0$%han@samsung.com>
On Tue, Feb 26, 2013 at 10:21:06AM +0900, Jingoo Han wrote:
> +/**
> + * devm_rtc_device_unregister - resource managed devm_rtc_device_unregister()
> + * @dev: the device to unregister
> + * @rtc: the RTC class device to unregister
> + *
> + * Deallocated a rtc allocated with devm_rtc_device_register(). Normally this
> + * function will not need to be called and the resource management code will
> + * ensure that the resource is freed.
> + */
> +void devm_rtc_device_unregister(struct device *dev, struct rtc_device *rtc)
Why do you need a separate function? You can add a flag to struct rtc_device
so it knows whether it is devm-managed or not and behave accordingly.
And then you can do
#define devm_rtc_device_unregister rtc_device_unregister
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-02-26 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 1:21 Jingoo Han
2013-02-26 1:23 ` 'Tejun Heo'
2013-02-26 1:30 ` 'Tejun Heo'
2013-02-26 1:42 ` Jingoo Han
2013-02-26 22:33 ` Dmitry Torokhov [this message]
2013-02-27 2:12 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226223304.GB20670@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®