mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kurachkin Michail <Michail.Kurachkin@promwad.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kuten Ivan <Ivan.Kuten@promwad.com>,
	"benavi@marvell.com" <benavi@marvell.com>,
	Viktar Palstsiuk <Viktar.Palstsiuk@promwad.com>,
	Gorokh Dmitriy <Dmitriy.Gorokh@promwad.com>
Subject: Re: [PATCH] staging: si3226x: TDM: add issues to TODO file
Date: Thu, 28 Feb 2013 08:57:20 -0800	[thread overview]
Message-ID: <20130228165720.GB6510@kroah.com> (raw)
In-Reply-To: <F7F628C32E67B04DAECC5CA53521253E6AD1BA22@sv-exmb01-lo1.promwad.corp>

On Thu, Feb 28, 2013 at 04:30:52PM +0000, Kurachkin Michail wrote:
> Signed-off-by: Michail Kurachkin <michail.kurachkin@promwad.com>
> ---
>  drivers/staging/si3226x/TODO |   20 +++++++++++++++++---
>  drivers/staging/tdm/TODO     |   19 +++++++++++++++++++
>  2 files changed, 36 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/staging/tdm/TODO
> 
> diff --git a/drivers/staging/si3226x/TODO b/drivers/staging/si3226x/TODO
> index b2cb27e..e4c334a 100644
> --- a/drivers/staging/si3226x/TODO
> +++ b/drivers/staging/si3226x/TODO
> @@ -1,8 +1,22 @@
> +Mainteiners:
> +Michail Kurachkin <Michail.Kurachkin@promwad.com> <stelhs@yandex.ru>
> +Ivan Kuten <ivan.kuten@promwad.com>
> +Promwad company <info@promwad.com>
> +
> +Reviwers:
> +Oliver Neukum <oneukum@suse.de>
> +Ryan Mallon <rmallon@gmail.com>
> +Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Why are you listing reviewers?  We've never done that in a TODO file
before, please don't start.

And this should be two patches, one for each driver.

In fact, ideally it would be part of your original series.  As I really
don't want to hand-edit the Subject: of those patches, can you just fix
this up properly and resend all of them, based on the comments I've
provided so far?

thanks,

greg k-h

      reply	other threads:[~2013-02-28 16:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 16:30 Kurachkin Michail
2013-02-28 16:57 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130228165720.GB6510@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Dmitriy.Gorokh@promwad.com \
    --cc=Ivan.Kuten@promwad.com \
    --cc=Michail.Kurachkin@promwad.com \
    --cc=Viktar.Palstsiuk@promwad.com \
    --cc=benavi@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®