Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

[Jean Delvare <khali@linux-fr.org>]

On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote:
> thanks for resending.

You're welcome.

> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare:
> > From: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
> > 
> > Convert the struct i2c_msg initialization to C99 format. This makes
> > maintaining and editing the code simpler. Also helps once other fields
> > like transferred are added in future.
> > 
> > Thanks to Julia Lawall for automating the conversion.
> > 
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> > Acked-by: Peter Huewe <peter.huewe@infineon.com>
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > ---
> > v2: removed zero initialization of flags.
> > 
> > Patch already sent by Shubhrajyoti Datta on 2012-10-10.
> > 
> >  drivers/char/tpm/tpm_i2c_infineon.c |   19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> As it was not yet applied I folded it into my patch
> "Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)"

I'd suggest not to. Mixing actual changes with cleanups is generally
discouraged.

-- 
Jean Delvare