From: Borislav Petkov <bp@alien8.de>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, len.brown@intel.com
Subject: Re: [PATCH] x86: fix 32-bit *_cpu_data initializers
Date: Sun, 3 Mar 2013 00:46:23 +0100 [thread overview]
Message-ID: <20130302234623.GB15498@pd.tnic> (raw)
In-Reply-To: <1362266082-2227-1-git-send-email-krzysiek@podlesie.net>
On Sun, Mar 03, 2013 at 12:14:42AM +0100, Krzysztof Mazur wrote:
> The commit 27be457000211a6903968dfce06d5f73f051a217
> (x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag)
> removed the hlt_works_ok flag from struct cpuinfo_x86, but
> boot_cpu_data and new_cpu_data initializers were not changed causing
> setting f00f_bug flag, instead of fdiv_bug. If CONFIG_X86_F00F_BUG
> is not set the f00f_bug flag is never cleared.
>
> To avoid such problems in future C99-style initialization is now used.
>
> Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Good catch.
Acked-by: Borislav Petkov <bp@suse.de>
> ---
> $ cat < /proc/cpuinfo
> processor : 0
> vendor_id : GenuineIntel
> cpu family : 6
> model : 13
> model name : Intel(R) Pentium(R) M processor 1.73GHz
> stepping : 8
> microcode : 0x20
> cpu MHz : 800.000
> cache size : 2048 KB
> fdiv_bug : no
> f00f_bug : yes
> ...
>
> By the way now in struct cpuinfo_x86 for 32-bit systems pad0
> should be extended to 2 bytes or removed, because now 32-bit
> specific bugs area have now 6 bytes + pad0.
It's good that you bring this up - I have a patchset which removes all
those *_bug fields in cpuinfo_x86 which means the padding goes away too.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-03-02 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 23:14 Krzysztof Mazur
2013-03-02 23:46 ` Borislav Petkov [this message]
2013-03-06 14:31 ` [tip:x86/urgent] x86: Fix " tip-bot for Krzysztof Mazur
2013-03-07 4:26 ` tip-bot for Krzysztof Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302234623.GB15498@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=krzysiek@podlesie.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®