From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: sam@ravnborg.org
Cc: dhowells@redhat.com, mmarek@suse.cz, arnd@arndb.de,
tglx@linutronix.de, paulmck@linux.vnet.ibm.com, davej@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
Date: Mon, 4 Mar 2013 07:03:19 +0900 [thread overview]
Message-ID: <201303040703.IIB34337.OJSQVOFtFFOMHL@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20130303153444.GA9329@merkur.ravnborg.org>
Sam Ravnborg wrote:
> On Mon, Mar 04, 2013 at 12:07:31AM +0900, Tetsuo Handa wrote:
> > Sam Ravnborg wrote:
> > > On Wed, Nov 28, 2012 at 01:55:14PM +0000, David Howells wrote:
> > > > Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> > > >
> > > > > Tetsuo Handa wrote:
> > > > > > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > > > > > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > > > > > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > > > > > Remove the objhdr-y export list".
> > > > >
> > > > > Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> > > > > installation and checking".
> > > >
> > > > Indeed, but that doesn't help much. The problem is that make's behaviour has
> > > > apparently changed. I could do with Sam Ravnborg's help to work around this
> > > > since I think he's mainly responsible for the Makefile infrastructure.
> > >
> > > Mical is the kbuild person these days.
> > > Anyway - it this still relevant?
> > >
> > Yes, as of commit a7c1120d "Merge tag 'ext4_for_linus' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4" in linux.git still
> > has this problem.
> >
> > > I took a quick look and my suspect is the use of $(or ..),
> > > as this feature was added recently to make.
>
> Hi Tetsuo.
>
> If my guess is correct this patch should help.
> I have gmake 3.81 and I do nto see the beforementioned problem.
Yes, I'm using 3.80 and this patch fixes my problem. Thank you.
>
> Sam
>
> diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
> index 25f216a..477d137 100644
> --- a/scripts/Makefile.headersinst
> +++ b/scripts/Makefile.headersinst
> @@ -14,7 +14,7 @@ kbuild-file := $(srctree)/$(obj)/Kbuild
> include $(kbuild-file)
>
> # called may set destination dir (when installing to asm/)
> -_dst := $(or $(destination-y),$(dst),$(obj))
> +_dst := $(if $(destination-y),$(destination-y),$(if $(dst),$(dst),$(obj)))
>
> old-kbuild-file := $(srctree)/$(subst uapi/,,$(obj))/Kbuild
> ifneq ($(wildcard $(old-kbuild-file)),)
> @@ -48,13 +48,14 @@ all-files := $(header-y) $(genhdr-y) $(wrapper-files)
> output-files := $(addprefix $(installdir)/, $(all-files))
>
> input-files := $(foreach hdr, $(header-y), \
> - $(or \
> + $(if $(wildcard $(srcdir)/$(hdr)), \
> $(wildcard $(srcdir)/$(hdr)), \
> - $(wildcard $(oldsrcdir)/$(hdr)), \
> - $(error Missing UAPI file $(srcdir)/$(hdr)) \
> + $(if $(wildcard $(oldsrcdir)/$(hdr)), \
> + $(wildcard $(oldsrcdir)/$(hdr)), \
> + $(error Missing UAPI file $(srcdir)/$(hdr))) \
> )) \
> $(foreach hdr, $(genhdr-y), \
> - $(or \
> + $(if $(wildcard $(gendir)/$(hdr)), \
> $(wildcard $(gendir)/$(hdr)), \
> $(error Missing generated UAPI file $(gendir)/$(hdr)) \
> ))
>
prev parent reply other threads:[~2013-03-03 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 13:27 Tetsuo Handa
2012-11-18 13:53 ` David Howells
2012-11-18 15:14 ` Tetsuo Handa
2012-11-19 11:10 ` David Howells
2012-11-19 13:02 ` Tetsuo Handa
[not found] ` <26846.1353334165@warthog.procyon.org.uk>
2012-11-20 14:22 ` Tetsuo Handa
2012-11-25 9:02 ` Tetsuo Handa
2012-11-28 13:55 ` David Howells
2013-03-03 12:02 ` Sam Ravnborg
2013-03-03 15:07 ` Tetsuo Handa
2013-03-03 15:34 ` Sam Ravnborg
2013-03-03 22:03 ` Tetsuo Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303040703.IIB34337.OJSQVOFtFFOMHL@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®