From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Kent Yoder <key@linux.vnet.ibm.com>
Cc: Peter Huewe <peter.huewe@infineon.com>,
tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, shpedoikal@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)
Date: Mon, 4 Mar 2013 11:59:52 -0700 [thread overview]
Message-ID: <20130304185952.GA24196@obsidianresearch.com> (raw)
In-Reply-To: <20130304174104.GA10811@ennui.austin.ibm.com>
On Mon, Mar 04, 2013 at 11:41:04AM -0600, Kent Yoder wrote:
> > .id_table = tpm_tis_i2c_table,
> > .probe = tpm_tis_i2c_probe,
> > .remove = tpm_tis_i2c_remove,
> > @@ -703,11 +759,12 @@ static struct i2c_driver tpm_tis_i2c_driver = {
> > .name = "tpm_i2c_infineon",
> > .owner = THIS_MODULE,
> > .pm = &tpm_tis_i2c_ops,
> > + .of_match_table = of_match_ptr(tpm_tis_i2c_of_match),
>
> Please put this line inside an ifdef CONFIG_OF, since of_match_ptr
> lives in there.
The OF stuff is designed to hide the CONFIG_OF from using code,
of_match_ptr(x) expends to NULL when CONFIG_OF is not set.
It is optional to include the MATCH_TABLE bit in a CONFI_OF #ifdef,
lots of places don't.
Jason
next prev parent reply other threads:[~2013-03-04 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 14:41 Peter Huewe
[not found] ` <20130304174104.GA10811@ennui.austin.ibm.com>
2013-03-04 18:59 ` Jason Gunthorpe [this message]
2013-03-04 19:54 ` [tpmdd-devel] " Peter Hüwe
2013-03-04 20:08 ` Kent Yoder
2013-03-04 20:16 ` Kent Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304185952.GA24196@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peter.huewe@infineon.com \
--cc=shpedoikal@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®