From: Jason Cooper <jason@lakedaemon.net>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
Date: Tue, 5 Mar 2013 09:00:25 -0500 [thread overview]
Message-ID: <20130305140025.GO23237@titan.lakedaemon.net> (raw)
In-Reply-To: <1362476098.16460.65.camel@x61.thuisdomein>
Paul,
On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h> we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks for the patch. Sebastian, could you test this and
report back?
thx,
Jason.
next prev parent reply other threads:[~2013-03-05 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 9:34 Paul Bolle
2013-03-05 14:00 ` Jason Cooper [this message]
2013-03-05 18:02 ` Jean-Francois Moine
2013-03-05 18:23 ` Paul Bolle
2013-03-05 18:34 ` Sebastian Hesselbarth
2013-03-05 20:17 ` [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE" Paul Bolle
2013-03-08 21:26 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305140025.GO23237@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pebolle@tiscali.nl \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®