From: Lars Poeschel <poeschel@lemonage.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
Date: Wed, 6 Mar 2013 11:38:21 +0100 [thread overview]
Message-ID: <201303061138.21776.poeschel@lemonage.de> (raw)
In-Reply-To: <1362486116.3660.1.camel@phoenix>
On Tuesday 05 March 2013 at 13:21:56, Axel Lin wrote:
> Set it once is enough, and it's done in vprbrd_gpiob_set() which is called
> by vprbrd_gpiob_direction_output().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thank you!
Tested-and-Acked-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> drivers/gpio/gpio-viperboard.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-viperboard.c
> b/drivers/gpio/gpio-viperboard.c index 59d7239..095ab14 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct
> gpio_chip *chip, struct vprbrd *vb = gpio->vb;
>
> gpio->gpiob_out |= (1 << offset);
> - if (value)
> - gpio->gpiob_val |= (1 << offset);
> - else
> - gpio->gpiob_val &= ~(1 << offset);
>
> mutex_lock(&vb->lock);
next prev parent reply other threads:[~2013-03-06 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 12:21 Axel Lin
2013-03-06 10:38 ` Lars Poeschel [this message]
2013-03-27 8:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303061138.21776.poeschel@lemonage.de \
--to=poeschel@lemonage.de \
--cc=axel.lin@ingics.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®