From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Cooks <acooks@gmail.com>
Cc: Dan Williams <djbw@fb.com>, Vinod Koul <vinod.koul@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][v2] check for dma mapping error in ioat_dma_self_test
Date: Wed, 6 Mar 2013 17:39:10 +0000 [thread overview]
Message-ID: <20130306173910.GU17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1362536245-4708-1-git-send-email-acooks@gmail.com>
Thanks for redoing the patch, but...
On Wed, Mar 06, 2013 at 10:17:22AM +0800, Andrew Cooks wrote:
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index 1879a59..5431ba8 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -832,7 +832,18 @@ int ioat_dma_self_test(struct ioatdma_device *device)
> }
>
> dma_src = dma_map_single(dev, src, IOAT_TEST_SIZE, DMA_TO_DEVICE);
> + if (dma_mapping_error(dev, dma_src)) {
> + dev_err(dev, "dma mapping failed.\n");
> + goto free_resources;
Won't this result in 'err' still being zero here, and cause this function
to apparantly return success?
prev parent reply other threads:[~2013-03-06 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 8:39 [PATCH] check for allocation failure " Andrew Cooks
2013-03-04 10:11 ` Russell King - ARM Linux
2013-03-06 1:57 ` Andrew Cooks
2013-03-06 2:17 ` [PATCH][v2] check for dma mapping error " Andrew Cooks
2013-03-06 17:39 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306173910.GU17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=acooks@gmail.com \
--cc=djbw@fb.com \
--cc=jassisinghbrar@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®