From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Brown <davidb@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] ssbi: Fix exit mismatch in remove function
Date: Thu, 7 Mar 2013 09:30:42 +0800 [thread overview]
Message-ID: <20130307013042.GB2910@kroah.com> (raw)
In-Reply-To: <1362616187-21089-4-git-send-email-davidb@codeaurora.org>
On Wed, Mar 06, 2013 at 04:29:44PM -0800, David Brown wrote:
> msm_ssbi_remove is referenced with __exit_p, but not declared with
> __exit. This causes a warning when the driver is not built as a
> module:
>
> drivers/ssbi/ssbi.c:341:23: warning: 'msm_ssbi_remove' defined but not used [-Wunused-function]
>
> Fix by adding the __exit declaration to the function.
>
> Signed-off-by: David Brown <davidb@codeaurora.org>
> ---
> drivers/ssbi/ssbi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssbi/ssbi.c b/drivers/ssbi/ssbi.c
> index 86d8416..4d503da 100644
> --- a/drivers/ssbi/ssbi.c
> +++ b/drivers/ssbi/ssbi.c
> @@ -337,7 +337,7 @@ err_get_mem_res:
> return ret;
> }
>
> -static int msm_ssbi_remove(struct platform_device *pdev)
> +static int __exit msm_ssbi_remove(struct platform_device *pdev)
No, remove the __exit_p marking instead, unless you want your kernel to
be oopsed :)
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-07 1:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 0:29 [PATCH 0/6] Qualcomm SSBI bus driver David Brown
2013-03-07 0:29 ` [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver David Brown
2013-03-07 1:30 ` Greg Kroah-Hartman
2013-03-07 5:20 ` David Brown
2013-03-07 6:01 ` Greg Kroah-Hartman
2013-03-07 10:05 ` Sekhar Nori
2013-03-07 18:45 ` David Brown
2013-03-07 18:50 ` David Brown
2013-03-07 23:29 ` Greg Kroah-Hartman
2013-03-12 6:51 ` David Brown
2013-03-12 13:27 ` Greg Kroah-Hartman
2013-03-07 0:29 ` [PATCH 2/6] SSBI: Convert SSBI to device tree David Brown
2013-03-07 0:29 ` [PATCH 3/6] ssbi: Fix exit mismatch in remove function David Brown
2013-03-07 1:30 ` Greg Kroah-Hartman [this message]
2013-03-07 5:21 ` David Brown
2013-03-07 0:29 ` [PATCH 4/6] ssbi: Use regular init level David Brown
2013-03-07 0:29 ` [PATCH 5/6] ARM: msm: enable SSBI driver in defconfig David Brown
2013-03-07 0:29 ` [PATCH 6/6] RFC: SSBI: Simple pm8058 test driver David Brown
2013-03-12 18:41 ` [PATCH v2 0/11] Qualcomm SSBI bus driver David Brown
2013-03-12 18:41 ` [PATCH v2 01/11] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver David Brown
2013-03-12 18:41 ` [PATCH v2 02/11] fix: Use EXPORT_SYMBOL_GPL David Brown
2013-03-12 18:41 ` [PATCH v2 03/11] ssbi: Fix exit mismatch in remove function David Brown
2013-03-12 18:41 ` [PATCH v2 04/11] ssbi: Allow compilation as a module David Brown
2013-03-12 18:41 ` [PATCH v2 05/11] SSBI: Convert SSBI to device tree David Brown
2013-03-12 20:46 ` Stephen Boyd
2013-03-12 18:41 ` [PATCH v2 06/11] ssbi: Comment the use of udelay() David Brown
2013-03-12 18:41 ` [PATCH v2 07/11] ssbi: Use regular init level David Brown
2013-03-12 20:26 ` Stephen Boyd
2013-03-12 18:41 ` [PATCH v2 08/11] ssbi: Remove extraneous logging David Brown
2013-03-12 18:41 ` [PATCH v2 09/11] SSBI: Remove MSM_ prefix from SSBI drivers David Brown
2013-03-12 18:41 ` [PATCH v2 10/11] MAINTAINERS: add ssbi David Brown
2013-03-25 17:40 ` [PATCH v2 0/11] Qualcomm SSBI bus driver Greg Kroah-Hartman
2013-03-12 20:12 ` [PATCH v2 11/11] RFC: SSBI: Simple pm8058 test driver David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307013042.GB2910@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®