Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08-03-2013 16:53, oskar.andero@sonymobile.com wrote:
> 
> >From: Truls Bengtsson <truls.bengtsson@sonymobile.com>
> 
> >The udc_irq service runs the isr_tr_complete_handler which in turn
> >"nukes" the endpoints, including a call to rndis_response_complete,
> >if appropriate. If the rndis_msg_parser fails here, an error will
> >be printed using a dev_err call (through the ERROR() macro).
> 
> >However, if the usb cable was just disconnected the device (cdev)
> >might not be available and will be null. Since the dev_err macro will
> >dereference the cdev pointer we get a null pointer exception.
> 
> >Reviewed-by: Radovan Lekanovic <radovan.lekanovic@sonymobile.com>
> >Signed-off-by: Truls Bengtsson <truls.bengtsson@sonymobile.com>
> >Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
> >---
> >  drivers/usb/gadget/f_rndis.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
> >index 71beeb8..41b5ebd 100644
> >--- a/drivers/usb/gadget/f_rndis.c
> >+++ b/drivers/usb/gadget/f_rndis.c
> >@@ -6,6 +6,7 @@
> >   * Copyright (C) 2008 Nokia Corporation
> >   * Copyright (C) 2009 Samsung Electronics
> >   *                    Author: Michal Nazarewicz (mina86@mina86.com)
> >+ * Copyright (C) 2013 Sony Mobile Communications AB.
> 
>    Your change seems too insignificant to add a copyright.

You are right, it legally is.  Truls, please consult your company's
lawyers if you have questions about this, you can not assert copyright
over a file for a 2 line change, that's not allowed at all in any
jurisdiction I know of.

Because of that, I can not accept this change, sorry.

greg k-h