From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, ibm-acpi@hmh.eng.br,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Aaron Lu <aaron.lu@intel.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Artem Savkov <artem.savkov@gmail.com>
Subject: Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex
Date: Sat, 9 Mar 2013 18:34:28 -0300 [thread overview]
Message-ID: <20130309213428.GB7559@khazad-dum.debian.net> (raw)
In-Reply-To: <CACBanvqP0jx_d-LtV5+fRD7M698M_b6j0Sv=v0uoTBpjEusQCw@mail.gmail.com>
On Thu, 07 Mar 2013, Mandeep Singh Baines wrote:
> On Thu, Mar 7, 2013 at 9:53 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex.
> >
> > We can simply kill this mutex, hotkey_poll_stop_sync() does not need
> > to serialize with hotkey_kthread(). When kthread_stop() returns the
> > thread is already dead, it called do_exit()->complete_vfork_done().
> >
> > Reported-by: Artem Savkov <artem.savkov@gmail.com>
> > Reported-by: Maciej Rutecki <maciej.rutecki@gmail.com>
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> >
>
> Reviewed-by: Mandeep Singh Baines <msb@chromium.org>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2013-03-09 21:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 19:55 [REGRESSION] [3.9-rc1] BUG: ktpacpi_nvramd/446 still has locks held! Maciej Rutecki
2013-03-05 7:28 ` Aaron Lu
2013-03-05 16:04 ` Mandeep Singh Baines
2013-03-05 17:34 ` [PATCH] thinkpad-acpi: fix potential suspend blocking issue Mandeep Singh Baines
2013-03-05 17:48 ` Oleg Nesterov
2013-03-05 17:59 ` Mandeep Singh Baines
2013-03-05 18:05 ` Oleg Nesterov
2013-03-05 20:55 ` Mandeep Singh Baines
2013-03-05 23:26 ` Henrique de Moraes Holschuh
2013-03-06 15:44 ` Oleg Nesterov
2013-03-06 23:32 ` Henrique de Moraes Holschuh
2013-03-07 17:53 ` [PATCH 0/1] thinkpad-acpi: kill hotkey_thread_mutex Oleg Nesterov
2013-03-07 17:53 ` [PATCH 1/1] " Oleg Nesterov
2013-03-07 18:42 ` Mandeep Singh Baines
2013-03-09 21:34 ` Henrique de Moraes Holschuh [this message]
2013-03-26 13:14 ` Rafael J. Wysocki
2013-03-26 13:09 ` Oleg Nesterov
2013-03-26 13:50 ` Rafael J. Wysocki
2013-03-05 19:18 ` [PATCH] thinkpad-acpi: fix potential suspend blocking issue Maciej Rutecki
2013-03-05 22:18 ` Andrew Morton
2013-03-06 15:50 ` Oleg Nesterov
2013-03-06 20:18 ` Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309213428.GB7559@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=artem.savkov@gmail.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®