From: Sean Young <sean@mess.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Josh Boyer <jwboyer@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 8250.nr_uarts broken in 3.7
Date: Sun, 10 Mar 2013 12:21:23 +0000 [thread overview]
Message-ID: <20130310122123.GA25551@pequod.mess.org> (raw)
In-Reply-To: <513B43BA.3000906@suse.cz>
On Sat, Mar 09, 2013 at 03:14:18PM +0100, Jiri Slaby wrote:
> This is so disgusting that I will do the following:
> * ack your patch after you change the above (if that works)
> * rename 8250.c to 8250_core.c
> * change 8250_core.ko back to 8250.ko (ie. bring back the old module name)
> * thus switch MODULE_PARAM_PREFIX above to "8250_core."
> * deprecate all the newly added 8250_core.* params somehow and schedule
> for removal. IMO this warrants a kernel config option like
> CONFIG_8250_DEPRECATED_MODULE_PARAMS.
>
> We have a lesson learned.
Indeed. In the patch that broke things, I renamed the module rather than
the 8250.c source file in order to keep the patch small, but obviously
did not consider the consequences well enough. I'm sorry about the mess
I created.
Sean
next prev parent reply other threads:[~2013-03-10 12:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 18:56 Josh Boyer
2013-03-07 18:58 ` Josh Boyer
2013-03-07 19:07 ` Jiri Slaby
2013-03-07 19:10 ` Josh Boyer
2013-03-07 21:14 ` Josh Boyer
2013-03-07 23:12 ` Greg Kroah-Hartman
2013-03-08 1:01 ` Josh Boyer
2013-03-08 1:39 ` Greg Kroah-Hartman
2013-03-08 21:27 ` Josh Boyer
2013-03-08 22:47 ` Jiri Slaby
2013-03-08 22:49 ` Josh Boyer
2013-03-08 22:58 ` Jiri Slaby
2013-03-08 23:10 ` Jiri Slaby
2013-03-08 23:14 ` Jiri Slaby
2013-03-08 23:28 ` Josh Boyer
2013-03-08 23:44 ` Josh Boyer
2013-03-09 9:14 ` Jiri Slaby
2013-03-09 13:30 ` Josh Boyer
2013-03-09 14:14 ` Jiri Slaby
2013-03-09 17:02 ` Josh Boyer
2013-03-10 14:33 ` [PATCH v2] serial: 8250: Keep 8250.<xxxx> module options functional after driver rename Josh Boyer
2013-03-10 22:33 ` Jiri Slaby
2013-03-10 12:21 ` Sean Young [this message]
2013-03-08 23:11 ` 8250.nr_uarts broken in 3.7 Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130310122123.GA25551@pequod.mess.org \
--to=sean@mess.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®