From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: clarify reasoning for the access_ok call
Date: Mon, 11 Mar 2013 21:13:26 +0000 [thread overview]
Message-ID: <20130311211326.GC31324@cantiga.alporthouse.com> (raw)
In-Reply-To: <CAGXu5j+v9ma5rwhtPqtJKzve5q5G_m9VQkAUqJ38VnDFPpvGYw@mail.gmail.com>
On Mon, Mar 11, 2013 at 02:04:51PM -0700, Kees Cook wrote:
> Probably not. It just seemed like the existing comment was
> insufficient after the removal of the redundant VERIFY_READ check that
> happened recently.
That's certainly true, the remaining comment is a little cryptic.
Something more like:
/* We need to check that we can read the entire relocation array, but
* as we may need to update the presumed_offsets upon execution, we
* need to check now for full write access.
*/
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2013-03-11 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 19:26 Kees Cook
2013-03-11 20:51 ` Chris Wilson
2013-03-11 21:04 ` Kees Cook
2013-03-11 21:13 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311211326.GC31324@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®