From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Danny Huang <dahuang@nvidia.com>
Cc: swarren@wwwdotorg.org, hdoyu@nvidia.com, olof@lixom.net,
gregkh@linuxfoundation.org, arnd@arndb.de, josephl@nvidia.com,
pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: tegra: expose chip ID and revision
Date: Tue, 12 Mar 2013 12:16:13 +0000 [thread overview]
Message-ID: <20130312121613.GT4977@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1363089667-15737-1-git-send-email-dahuang@nvidia.com>
On Tue, Mar 12, 2013 at 08:01:07PM +0800, Danny Huang wrote:
> + if (IS_ERR_OR_NULL(soc_dev))
Sigh. NAK. Fur cryin out loud! Use the IS_ERR() version.
And you don't need the following "return;" statement - that's already
implied at the closing brace of a function.
next prev parent reply other threads:[~2013-03-12 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 12:01 Danny Huang
2013-03-12 12:16 ` Russell King - ARM Linux [this message]
2013-03-12 12:59 ` Arnd Bergmann
2013-03-12 18:04 ` Stephen Warren
2013-03-12 19:10 ` Arnd Bergmann
2013-03-12 19:45 ` Stephen Warren
2013-03-12 17:58 ` Stephen Warren
2013-03-12 18:01 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312121613.GT4977@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=dahuang@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdoyu@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®