From: Tejun Heo <tj@kernel.org>
To: Artem Savkov <artem.savkov@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
viakernel.org@htj.dyndns.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()
Date: Wed, 13 Mar 2013 10:57:45 -0700 [thread overview]
Message-ID: <20130313175745.GA22267@htj.dyndns.org> (raw)
In-Reply-To: <1363197092-4832-1-git-send-email-artem.savkov@gmail.com>
(cc'ing Stephen and linux-next)
Hello, Artem.
On Wed, Mar 13, 2013 at 09:51:32PM +0400, Artem Savkov wrote:
> Added missing idr_preload_end() call in worker_pool_assign_id().
> Without it preemption stays disabled resulting in lots of "scheduling while
> atomic" BUGs during boot.
...
> Introduced in "workqueue: convert to idr_alloc()"
That patch doesn't use idr_preload(). It looks like the issue is
introduced during linux-next merge of wq/for-3.10 and idr patches in
-mm. Stephen, can you please add idr_preload_end() to the merge
patch?
Once the idr patches land in Linus' tree, I'll resolve the conflict
from wq tree side.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-03-13 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 17:51 Artem Savkov
2013-03-13 17:57 ` Tejun Heo [this message]
2013-03-13 21:51 ` Stephen Rothwell
2013-03-13 21:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313175745.GA22267@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=artem.savkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viakernel.org@htj.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®