From: Felipe Balbi <balbi@ti.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: <linux-usb@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <balbi@ti.com>,
<rob.herring@calxeda.com>, <kgene.kim@samsung.com>,
<thomas.abraham@linaro.org>, <dianders@chromium.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev
Date: Thu, 14 Mar 2013 12:51:55 +0200 [thread overview]
Message-ID: <20130314105155.GG32369@arwen.pp.htv.fi> (raw)
In-Reply-To: <1363257898-17504-2-git-send-email-gautam.vivek@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
Hi,
On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
> {
> struct dwc3_exynos *exynos = platform_get_drvdata(pdev);
>
> - platform_device_unregister(exynos->dwc3);
don't you want to do what Kishon did here and have:
static int dwc3_exynos_remove_child(struct device *dev, void *unused)
{
struct platform_device *pdev = to_platform_device(dev);
platform_device_unregister(pdev);
return 0;
}
device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child);
???
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-14 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 10:44 [PATCH 0/2] dwc3: exynos: Device tree fixes Vivek Gautam
2013-03-14 10:44 ` [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev Vivek Gautam
2013-03-14 10:51 ` Felipe Balbi [this message]
2013-03-14 12:10 ` Vivek Gautam
2013-03-14 12:39 ` [PATCH v2 " Vivek Gautam
2013-03-14 10:44 ` [PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare Vivek Gautam
2013-03-14 10:53 ` Felipe Balbi
2013-03-15 6:06 ` Vivek Gautam
2013-03-15 7:42 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314105155.GG32369@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®