mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: lineage-pem: Add missing terminating entry for  pem_[input|fan]_attributes
Date: Thu, 14 Mar 2013 11:23:54 +0100	[thread overview]
Message-ID: <20130314112354.31396c51@endymion.delvare> (raw)
In-Reply-To: <1363249638.15861.1.camel@phoenix>

Hi Axel,

On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/hwmon/lineage-pem.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
> index 41df29f..ebbb9f4 100644
> --- a/drivers/hwmon/lineage-pem.c
> +++ b/drivers/hwmon/lineage-pem.c
> @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = {
>  	&sensor_dev_attr_in2_input.dev_attr.attr,
>  	&sensor_dev_attr_curr1_input.dev_attr.attr,
>  	&sensor_dev_attr_power1_input.dev_attr.attr,
> +	NULL
>  };
>  
>  static const struct attribute_group pem_input_group = {
> @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = {
>  	&sensor_dev_attr_fan1_input.dev_attr.attr,
>  	&sensor_dev_attr_fan2_input.dev_attr.attr,
>  	&sensor_dev_attr_fan3_input.dev_attr.attr,
> +	NULL
>  };
>  
>  static const struct attribute_group pem_fan_group = {

Good catch.

Acked-by: Jean Delvare <khali@linux-fr.org>

I'll let Guenter pick the fix as this is his driver. This should go to
stable too.

-- 
Jean Delvare

  reply	other threads:[~2013-03-14 10:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  8:27 Axel Lin
2013-03-14 10:23 ` Jean Delvare [this message]
2013-03-14 13:33   ` Guenter Roeck
2013-03-14 15:08     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130314112354.31396c51@endymion.delvare \
    --to=khali@linux-fr.org \
    --cc=axel.lin@ingics.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®