From: Guenter Roeck <linux@roeck-us.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Jean Delvare <khali@linux-fr.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) Fix krealloc() misuse in pmbus_add_attribute()
Date: Thu, 14 Mar 2013 06:59:27 -0700 [thread overview]
Message-ID: <20130314135927.GA16825@roeck-us.net> (raw)
In-Reply-To: <1363267820.4853.41.camel@i7.infradead.org>
On Thu, Mar 14, 2013 at 01:30:20PM +0000, David Woodhouse wrote:
> If krealloc() returns NULL, it *doesn't* free the original. So any code
> of the form 'foo = krealloc(foo, …);' is almost certainly a bug.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Good catch. Thanks a lot for the fix!
Guenter
next prev parent reply other threads:[~2013-03-14 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:30 David Woodhouse
2013-03-14 13:59 ` Guenter Roeck [this message]
2013-03-14 16:18 ` [PATCH] checkpatch: Add check for reuse of krealloc arg Joe Perches
2013-03-14 16:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314135927.GA16825@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dwmw2@infradead.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®