From: Greg KH <gregkh@linuxfoundation.org>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org,
Juan David Gonzalez Cobas <dcobas@cern.ch>,
"Emilio G. Cota" <cota@braap.org>,
Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/8] FMC: add core bus driver
Date: Fri, 15 Mar 2013 12:17:29 -0700 [thread overview]
Message-ID: <20130315191729.GA11988@kroah.com> (raw)
In-Reply-To: <bfc3a24221b75d3a742da638102e25bea70ca930.1361469466.git.rubini@gnudd.com>
On Thu, Feb 21, 2013 at 07:14:01PM +0100, Alessandro Rubini wrote:
> -/* Every device must have a release method: provide a default */
> +/* We really have nothing to release in here */
> static void __fmc_release(struct device *dev) { }
Then your implementation is wrong, and as per the documentation in the
kernel Documentation directory (kobject.txt), I get to make fun of you
in public for trying to do this :)
Please fix this up, this isn't ok.
greg k-h
next prev parent reply other threads:[~2013-03-15 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 18:13 [PATCH RFC 0/8] drivers/fmc: bus support for ANSI-VITA 57.1 Alessandro Rubini
2013-02-21 18:13 ` [PATCH 1/8] FMC: create drivers/fmc and toplevel Kconfig question Alessandro Rubini
2013-02-21 18:13 ` [PATCH 2/8] FMC: add needed headers Alessandro Rubini
2013-02-21 18:14 ` [PATCH 3/8] FMC: add core bus driver Alessandro Rubini
2013-03-15 19:17 ` Greg KH [this message]
2013-02-21 18:14 ` [PATCH 4/8] FMC: add documentation for the core Alessandro Rubini
2013-02-23 18:21 ` Rob Landley
2013-02-23 22:56 ` Alessandro Rubini
2013-02-21 18:14 ` [PATCH 5/8] FMC: add a software carrier driver Alessandro Rubini
2013-02-21 18:14 ` [PATCH 6/8] FMC: add a software mezzanine driver Alessandro Rubini
2013-02-21 18:14 ` [PATCH 7/8] FMC: add a driver to write mezzanine EEPROM Alessandro Rubini
2013-02-21 18:14 ` [PATCH 8/8] FMC: add a char-device mezzanine driver Alessandro Rubini
2013-06-12 7:13 [PATCH 0/8] Support for FMC carriers and mezzanines Alessandro Rubini
2013-06-12 7:13 ` [PATCH 3/8] FMC: add core bus driver Alessandro Rubini
2013-06-17 23:15 ` Greg KH
2013-06-17 23:16 ` Greg KH
2013-06-17 23:38 ` Alessandro Rubini
2013-06-18 8:36 ` Juan David Gonzalez Cobas
[not found] ` <CADDK0KdrVgmXN-TZw8E43JRNk5Wb_cfM6pUWaSxbJ49GU72cTg@mail.gmail.com>
2013-06-18 17:40 ` Greg KH
2013-06-18 19:52 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315191729.GA11988@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cota@braap.org \
--cc=dcobas@cern.ch \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=rubini@gnudd.com \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome