From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932576Ab3CQQNW (ORCPT ); Sun, 17 Mar 2013 12:13:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:45869 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755923Ab3CQQNU (ORCPT ); Sun, 17 Mar 2013 12:13:20 -0400 Date: Sun, 17 Mar 2013 12:13:18 -0400 (EDT) Message-Id: <20130317.121318.1869489921021513474.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: jasowang@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, edumazet@google.com Subject: Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission From: David Miller In-Reply-To: <1363399851.29475.52.camel@edumazet-glaptop> References: <1363333305-54398-1-git-send-email-jasowang@redhat.com> <1363333305-54398-2-git-send-email-jasowang@redhat.com> <1363399851.29475.52.camel@edumazet-glaptop> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Sun, 17 Mar 2013 09:13:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Fri, 15 Mar 2013 19:10:51 -0700 > Any way we can avoid adding this to fast path, for people not using > macvtap and ixgbe ? Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed packets to the rest of the stack.