From: Oleg Nesterov <oleg@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Anton Arapov <anton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: Use file_inode()
Date: Sun, 17 Mar 2013 19:42:55 +0100 [thread overview]
Message-ID: <20130317184255.GA23280@redhat.com> (raw)
In-Reply-To: <20130317182550.GD21522@ZenIV.linux.org.uk>
On 03/17, Al Viro wrote:
>
> On Sun, Mar 17, 2013 at 07:00:36PM +0100, Oleg Nesterov wrote:
> > Cleanup. Now that we have f_inode/file_inode() we can use it
> > instead of ->f_mapping->host.
>
> No. This is *not* guaranteed to be the same thing in general; note that
> e.g. for block devices ->f_mapping->host is *not* equal to file_inode().
Yes,
> It probably is valid in this particular case,
And yes (I think). In fact I think ->f_mode is "more correct" in this case.
Say, if this uprobe was created by create_trace_uprobe() we use d_inode,
and uprobe_mmap/etc uses file_inode() only to compare this pointer with
uprobe->inode.
But I'll try to recheck, and:
> but at the very least you
> need to explain that in commit message,
OK. Will do, thanks.
Oleg.
next prev parent reply other threads:[~2013-03-17 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 18:00 Oleg Nesterov
2013-03-17 18:25 ` Al Viro
2013-03-17 18:42 ` Oleg Nesterov [this message]
2013-03-18 18:43 ` [PATCH v2] " Oleg Nesterov
2013-03-21 6:06 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317184255.GA23280@redhat.com \
--to=oleg@redhat.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome