From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932689Ab3CQVqz (ORCPT ); Sun, 17 Mar 2013 17:46:55 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:48765 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932476Ab3CQVqv (ORCPT ); Sun, 17 Mar 2013 17:46:51 -0400 Date: Sun, 17 Mar 2013 21:46:42 +0000 From: Will Deacon To: Jiang Liu Cc: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2, part3 02/12] mm/ARM64: kill poison_init_mem() Message-ID: <20130317214642.GA20875@mudshark.cambridge.arm.com> References: <1363453413-8139-1-git-send-email-jiang.liu@huawei.com> <1363453413-8139-3-git-send-email-jiang.liu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363453413-8139-3-git-send-email-jiang.liu@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 16, 2013 at 05:03:23PM +0000, Jiang Liu wrote: > Use free_reserved_area() to kill poison_init_mem() on ARM64. > > Signed-off-by: Jiang Liu > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm64/mm/init.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index e58dd7f..b87bdb8 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -197,14 +197,6 @@ void __init bootmem_init(void) > max_pfn = max_low_pfn = max; > } > > -/* > - * Poison init memory with an undefined instruction (0x0). > - */ > -static inline void poison_init_mem(void *s, size_t count) > -{ > - memset(s, 0, count); > -} > - > #ifndef CONFIG_SPARSEMEM_VMEMMAP > static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) > { > @@ -386,8 +378,7 @@ void __init mem_init(void) > > void free_initmem(void) > { > - poison_init_mem(__init_begin, __init_end - __init_begin); > - free_initmem_default(-1); > + free_initmem_default(0); This change looks unrelated to $subject. We should probably just poison with 0 from the outset, when free_initmem_default is introduced. Will