From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757720Ab3CSUX2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Mar 2013 16:23:28 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:48008 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757393Ab3CSUXZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Mar 2013 16:23:25 -0400
Date: Tue, 19 Mar 2013 16:23:24 -0400 (EDT)
Message-Id: <20130319.162324.1623264491858670284.davem@davemloft.net>
To: sam@ravnborg.org
Cc: pebolle@tiscali.nl, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: remove unused "config BITS"
From: David Miller <davem@davemloft.net>
In-Reply-To: <20130319201454.GA25072@merkur.ravnborg.org>
References: <20130319.123306.1709006318806942163.davem@davemloft.net>
	<1363712807.1390.26.camel@x61.thuisdomein>
	<20130319201454.GA25072@merkur.ravnborg.org>
X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Tue, 19 Mar 2013 13:23:29 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 19 Mar 2013 21:14:54 +0100

> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
>> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
>> > We use this in the Makefile fragments, you cannot remove it.
>> 
>> >From arch/sparc/Makefile:
>>     ifeq ($(CONFIG_SPARC32),y)
>>     [...]
>> 
>>     [...]
>>     export BITS    := 32
>>     [...]
>> 
>>     else
>>     [...]
>> 
>>     [...]
>>     export BITS   := 64
>>     [...]
>> 
>> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
>> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
>> doesn't count as usage of "config BITS". 
> Just double checked - you are right.
> Maybe send a v2 with this info in changelog and add my:
> 
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

No need, I'll fix up the commit message.