From: Andrew Morton <akpm@linux-foundation.org>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, <linux-kernel@vger.kernel.org>,
<devel@openvz.org>, Doug Ledford <dledford@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] mqueue: sys_mq_open: do not call mnt_drop_write() if read-only
Date: Tue, 19 Mar 2013 14:09:40 -0700 [thread overview]
Message-ID: <20130319140940.fa84e0b678235076815fce64@linux-foundation.org> (raw)
In-Reply-To: <1363685478-9997-1-git-send-email-vdavydov@parallels.com>
On Tue, 19 Mar 2013 13:31:18 +0400 Vladimir Davydov <vdavydov@parallels.com> wrote:
> mnt_drop_write() must be called only if mnt_want_write() succeeded,
> otherwise the mnt_writers counter will diverge.
>
> ...
>
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -840,7 +840,8 @@ out_putfd:
> fd = error;
> }
> mutex_unlock(&root->d_inode->i_mutex);
> - mnt_drop_write(mnt);
> + if (!ro)
> + mnt_drop_write(mnt);
> out_putname:
> putname(name);
> return fd;
huh, that's been there for a while. What were the runtime-visible
effects of the bug?
next prev parent reply other threads:[~2013-03-19 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 9:31 Vladimir Davydov
2013-03-19 21:09 ` Andrew Morton [this message]
2013-03-19 22:04 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319140940.fa84e0b678235076815fce64@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=dledford@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vdavydov@parallels.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®