From: Andrew Morton <akpm@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 1/4] posix_cpu_timer: Consolidate expiry time type
Date: Tue, 19 Mar 2013 15:43:26 -0700 [thread overview]
Message-ID: <20130319154326.f8fd35776086c66617a08c90@linux-foundation.org> (raw)
In-Reply-To: <1363366442-11494-2-git-send-email-fweisbec@gmail.com>
On Fri, 15 Mar 2013 17:53:59 +0100 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> The posix cpu timer expiry time is stored in a union of
> two types: a 64 bits field if we rely on scheduler precise
> accounting, or a cputime_t if we rely on jiffies.
>
> This result in quite some duplicate code and special cases
> to handle the two types.
>
> Just unify this into a single 64 bits field. cputime_t can
> always fit into it.
>
x86_64 allnoconfig:
kernel/posix-cpu-timers.c: In function 'posix_cpu_timer_schedule':
kernel/posix-cpu-timers.c:1127: warning: 'now' may be used uninitialized in this function
It looks like it's always been buggy, but your switch from `union
cou_time_count' to `unsigned long long' made gcc notice it.
next prev parent reply other threads:[~2013-03-19 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 16:53 [PATCH 0/4] posix_cpu_timers: Some code consolidation v2 Frederic Weisbecker
2013-03-15 16:53 ` [PATCH 1/4] posix_cpu_timer: Consolidate expiry time type Frederic Weisbecker
2013-03-19 22:43 ` Andrew Morton [this message]
2013-03-20 0:25 ` Frederic Weisbecker
2013-03-15 16:54 ` [PATCH 2/4] posix_cpu_timers: Consolidate timer list cleanups Frederic Weisbecker
2013-03-15 16:54 ` [PATCH 3/4] posix_cpu_timers: Consolidate expired timers check Frederic Weisbecker
2013-03-15 16:54 ` [PATCH 4/4] selftests: Add basic posix timers selftests Frederic Weisbecker
2013-03-18 21:26 ` Andrew Morton
2013-03-18 21:32 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319154326.f8fd35776086c66617a08c90@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=sgruszka@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®