mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"feng.tang@intel.com" <feng.tang@intel.com>
Subject: Re: Perf tool won't build without libnewt
Date: Wed, 20 Mar 2013 13:38:21 +0000	[thread overview]
Message-ID: <20130320133820.GA15279@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <20130320132322.GE23423@infradead.org>

On Wed, Mar 20, 2013 at 01:23:22PM +0000, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 20, 2013 at 12:11:11PM +0000, Mark Rutland escreveu:
> > I attempted to cross-build v3.9-rc3's perf tool for an arm system today, and
> > got the following out of the build system:
> > 
> > CHK libnewt
> > Makefile:655: newt not found, disables TUI support. Please install newt-devel or libnewt-dev
> > [...]
> > builtin-report.c: In function ‘__cmd_report’:
> > builtin-report.c:478:15: error: ‘K_SWITCH_INPUT_DATA’ undeclared (first use in this function)
> > builtin-report.c:478:15: note: each undeclared identifier is reported only once for each function it appears in
> > builtin-report.c: In function ‘cmd_report’:
> > builtin-report.c:821:13: error: ‘K_SWITCH_INPUT_DATA’ undeclared (first use in this function)
> > make: *** [builtin-report.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > 
> > I've bisected this down to ad0de0971b: "perf report: Enable the runtime
> > switching of perf data file".
> 
> Can you try with latest tip/perf/urgent, should go to Linus soon.
> 
> This cset should fix it:

Indeed it does.

> 
> commit 5f7439e07822942f32b9e0a66f4a3cc9c3e29e67
> Author: Michael Ellerman <michael@ellerman.id.au>
> Date:   Tue Feb 26 16:02:03 2013 +1100
> 
>     perf report: Fix build with NO_NEWT=1
> 
> ----
> 
> 	Thanks for reporting!
> 
> - Arnaldo

Cheers,
Mark.

      reply	other threads:[~2013-03-20 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 12:11 Mark Rutland
2013-03-20 13:23 ` Arnaldo Carvalho de Melo
2013-03-20 13:38   ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320133820.GA15279@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=feng.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®