From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: LW@KARO-electronics.de, richardcochran@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH] net: ethernet: cpsw: fix erroneous condition in error check
Date: Thu, 21 Mar 2013 11:57:57 -0400 (EDT) [thread overview]
Message-ID: <20130321.115757.176260167306171131.davem@davemloft.net> (raw)
In-Reply-To: <514AFDD5.9020608@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Thu, 21 Mar 2013 18:02:21 +0530
> On 3/21/2013 5:50 PM, Lothar Waßmann wrote:
>> The error check in cpsw_probe_dt() has an '&&' where an '||' is
>> meant to be. This causes a NULL pointer dereference when incomplet DT
>> data is passed to the driver ('phy_id' property for cpsw_emac1
>> missing).
>>
>>
>> Signed-off-by: Lothar Waßmann<LW@KARO-electronics.de>
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied, thanks.
prev parent reply other threads:[~2013-03-21 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 12:20 Lothar Waßmann
2013-03-21 12:32 ` Mugunthan V N
2013-03-21 15:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321.115757.176260167306171131.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=LW@KARO-electronics.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®