From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932078Ab3CULc6 (ORCPT ); Thu, 21 Mar 2013 07:32:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55222 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147Ab3CULcz (ORCPT ); Thu, 21 Mar 2013 07:32:55 -0400 Date: Thu, 21 Mar 2013 12:32:52 +0100 From: Jan Kara To: Tejun Heo Cc: Dave Chinner , Jan Kara , axboe@kernel.dk, laijs@cn.fujitsu.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, jmoyer@redhat.com Subject: Re: [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue Message-ID: <20130321113252.GA30777@quack.suse.cz> References: <1362692649-25570-1-git-send-email-tj@kernel.org> <1362692649-25570-4-git-send-email-tj@kernel.org> <20130312150510.GF13152@quack.suse.cz> <20130318223244.GA11188@quack.suse.cz> <20130318223526.GH3042@htj.dyndns.org> <20130319154600.GC5222@quack.suse.cz> <20130321015721.GL17758@dastard> <20130321050718.GA8012@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130321050718.GA8012@mtj.dyndns.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 20-03-13 22:07:18, Tejun Heo wrote: > Hello, Dave. > > On Thu, Mar 21, 2013 at 12:57:21PM +1100, Dave Chinner wrote: > > When you have a system that has 50+ active filesystems (pretty > > common in the distributed storage environments were every disk has > > it's own filesystem), knowing which filesystem(s) are getting stuck > > in writeback from the sysrq-w or hangcheck output is pretty damn > > important.... > > Hmm... I guess, then, what we can do is adding a worker description > which is printed out with task dump. ie. A work function can call > work_set_desc(fmt, arg....). It won't be expensive and can be > implemented relatively easily. Does that sound good enough? Yeah, that sounds good! Thanks! Honza -- Jan Kara SUSE Labs, CR