From: Eric Wong <normalperson@yhbt.net>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Davide Libenzi <davidel@xmailserver.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] wfcqueue: functions for local append and enqueue
Date: Thu, 21 Mar 2013 11:43:13 +0000 [thread overview]
Message-ID: <20130321114313.GA17275@dcvr.yhbt.net> (raw)
In-Reply-To: <20130311213602.GB9829@Krystal>
With level-triggered epoll, append/enqueue operations to the
local/locked queues increase performance by avoiding unnecessary atomic
operations and barriers. These are necessary to avoid performance
regressions when looping through ep_send_events and appending many
items to a queue.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Davide Libenzi <davidel@xmailserver.org>
---
Benchmark for this coming with updated epoll patches.
include/linux/wfcqueue.h | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/include/linux/wfcqueue.h b/include/linux/wfcqueue.h
index 9464a0c..7eb2aaa 100644
--- a/include/linux/wfcqueue.h
+++ b/include/linux/wfcqueue.h
@@ -205,6 +205,49 @@ static inline bool wfcq_enqueue(struct wfcq_head *head,
}
/*
+ * __wfcq_append_local: append one local queue to another local queue
+ *
+ * No memory barriers are issued. Mutual exclusion is the responsibility
+ * of the caller.
+ *
+ * Returns false if the queue was empty prior to adding the node.
+ * Returns true otherwise.
+ */
+static inline bool __wfcq_append_local(struct wfcq_head *head,
+ struct wfcq_tail *tail,
+ struct wfcq_node *new_head,
+ struct wfcq_node *new_tail)
+{
+ struct wfcq_node *old_tail;
+
+ old_tail = tail->p;
+ tail->p = new_tail;
+ old_tail->next = new_head;
+
+ /*
+ * Return false if queue was empty prior to adding the node,
+ * else return true.
+ */
+ return old_tail != &head->node;
+}
+
+/*
+ * wfcq_enqueue_local: enqueue a node into a local wait-free queue
+ *
+ * No memory barriers are issued. Mutual exclusion is the responsibility
+ * of the caller.
+ *
+ * Returns false if the queue was empty prior to adding the node.
+ * Returns true otherwise.
+ */
+static inline bool wfcq_enqueue_local(struct wfcq_head *head,
+ struct wfcq_tail *tail,
+ struct wfcq_node *new_tail)
+{
+ return __wfcq_append_local(head, tail, new_tail, new_tail);
+}
+
+/*
* ___wfcq_busy_wait: busy-wait.
*/
static inline void ___wfcq_busy_wait(void)
--
1.8.2.rc3.2.g89ce8d6
next prev parent reply other threads:[~2013-03-21 11:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 21:36 [RFC PATCH] Linux kernel Wait-Free Concurrent Queue Implementation Mathieu Desnoyers
2013-03-14 4:22 ` Eric Wong
2013-03-14 13:18 ` Mathieu Desnoyers
2013-03-14 19:07 ` Eric Wong
2013-03-14 19:48 ` Mathieu Desnoyers
2013-03-14 21:32 ` Eric Wong
2013-03-15 2:38 ` Mathieu Desnoyers
2013-03-16 22:02 ` Eric Wong
2013-03-17 2:03 ` Mathieu Desnoyers
2013-03-18 10:37 ` Eric Wong
2013-03-15 0:49 ` Peter Hurley
2013-03-15 2:08 ` Mathieu Desnoyers
2013-03-21 11:43 ` Eric Wong [this message]
2013-03-22 2:01 ` [PATCH] wfcqueue: functions for local append and enqueue Mathieu Desnoyers
2013-03-22 10:31 ` Eric Wong
2013-03-23 19:07 ` [PATCH v2] " Eric Wong
2013-03-23 19:43 ` Mathieu Desnoyers
2013-03-23 20:42 ` [PATCH v3] " Eric Wong
2013-03-23 22:10 ` Mathieu Desnoyers
2013-03-29 8:10 ` [PATCH] wfcqueue: add function for unsynchronized prepend Eric Wong
2013-04-02 13:05 ` Mathieu Desnoyers
2013-04-02 21:15 ` Eric Wong
2013-04-06 21:42 ` [RFC PATCH] wfcqueue: implement __wfcq_enqueue_head() Mathieu Desnoyers
2013-04-11 21:23 ` [RFC PATCH] Linux kernel Wait-Free Concurrent Queue Implementation Eric Wong
2013-04-11 22:44 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321114313.GA17275@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=davidel@xmailserver.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®