From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057Ab3CVLdr (ORCPT ); Fri, 22 Mar 2013 07:33:47 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41881 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932521Ab3CVLdp (ORCPT ); Fri, 22 Mar 2013 07:33:45 -0400 Date: Fri, 22 Mar 2013 11:32:51 +0000 From: Russell King - ARM Linux To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Lior Amsalem , Ike Pan , Grant Likely , David Marlin , Yehuda Yitschak , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Ezequiel Garcia , Leif Lindholm , Sebastian Hesselbarth , Arnd Bergmann , Jon Masters , devicetree-discuss@lists.ozlabs.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Chris Van Hoof , Nicolas Pitre , linux-kernel@vger.kernel.org, Maen Suleiman , Nadav Haklai , Shadi Ammouri , Olof Johansson Subject: Re: [PATCH 2/5] arm: mvebu: Select DMA_BOUNCE when LPAE is selected in Kconfig Message-ID: <20130322113251.GB4977@n2100.arm.linux.org.uk> References: <1363883179-1361-1-git-send-email-gregory.clement@free-electrons.com> <1363883179-1361-3-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363883179-1361-3-git-send-email-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2013 at 05:26:15PM +0100, Gregory CLEMENT wrote: > From: Lior Amsalem > > For mvebu IOs are 32 bits and we have 40 bits memory due to LPAE so > make sure we give 32 bits addresses to the IOs. > > Signed-off-by: Lior Amsalem > Tested-by: Franklin > Signed-off-by: Gregory CLEMENT Oh god no. Please move away from the addition on DMABOUNCE - that code creaks, doesn't have highmem support, and is known to give problems on various platforms. Instead, please rely on using the DMA mask and such like, just like on x86.