From: Wim Van Sebroeck <wim@iguana.be>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Pádraig Brady" <P@draigBrady.com>
Subject: Re: [PATCH v2 0/8] watchdog: w83627hf: Convert to watchdog infrastructure
Date: Fri, 22 Mar 2013 21:52:58 +0100 [thread overview]
Message-ID: <20130322205258.GE7867@spo001.leaseweb.com> (raw)
In-Reply-To: <1362957300-18223-1-git-send-email-linux@roeck-us.net>
Hi Guenter,
> Convert to watchdog infrastructure, cleanup, add support for additional
> chips, and merge with W83697HF and W83697UG watchdog drivers.
>
> Tested with W83627UHG, NCT6775, NCT6776. Additional test feedback
> for other chips would be appreciated.
>
> Original idea was to prepare the driver for use as a client to an MFD driver,
> but I found that requesting memory with request_muxed_region works just as well
> and has less impact. v2 includes the knowledge gained from converting the
> driver to an MFD client driver, but without the actual conversion.
>
> v2: Tested with W83627UHG
> Retain timeout module parameter; use watchdog_init_timeout to set it
> Eliminate some cosmetic changes
> Drop spinlock.h include
> Keep "initialized" message
> Don't try to configure WDTO for W83627UHG and W83627EHF
> Don't report the nowayout option with the 'initializing' message
> Use request_muxed_region to reserve memory range only while needed
> Add support for W83627S, W83627DHG-P, W83667HG, and NCT6779
In 2011 I started something similar but then with the MFD approach in mind.
Goal was also to clean-up the w836* watchdog drivers and get a clean driver that
supports all Winbond super-I/O based watchdog drivers.
I dug op the development code again. I'll post it in a next e-mail so that we can
see what the best way forward is. Note: I took the MFD approach because:
1) all superio shares the similar functions for using the Super-I/O registers.
2) Goal is to have low-level driver that support the specific super-I/O chipsets
and that does the platform stuff for hwmon, watchdog, gpio, ...
Kind regards,
Wim.
next prev parent reply other threads:[~2013-03-22 20:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 23:14 Guenter Roeck
2013-03-10 23:14 ` [PATCH v2 1/7] " Guenter Roeck
2013-03-10 23:14 ` [PATCH v2 2/7] watchdog: w83627hf: Enable watchdog only once Guenter Roeck
2013-03-19 17:26 ` Pádraig Brady
2013-03-19 20:02 ` Guenter Roeck
2013-03-21 18:40 ` Pádraig Brady
2013-03-10 23:14 ` [PATCH v2 3/7] watchdog: w83627hf: Enable watchdog device only if not already enabled Guenter Roeck
2013-03-10 23:14 ` [PATCH v2 4/7] watchdog: w83627hf: Use helper functions to access superio registers Guenter Roeck
2013-03-10 23:14 ` [PATCH v2 5/7] watchdog: w83627hf: Auto-detect IO address and supported chips Guenter Roeck
2013-03-10 23:14 ` [PATCH v2 6/7] watchdog: w83627hf: Add support for W83697HF and W83697UG Guenter Roeck
2013-03-10 23:15 ` [PATCH v2 7/7] watchdog: Remove drivers " Guenter Roeck
2013-03-22 20:52 ` Wim Van Sebroeck [this message]
2013-03-22 21:09 ` [RFC] winbond Super-I/O MFD driver Wim Van Sebroeck
2013-03-23 0:28 ` [PATCH v2 0/8] watchdog: w83627hf: Convert to watchdog infrastructure Guenter Roeck
2013-03-23 12:57 ` Wim Van Sebroeck
2013-03-23 15:01 ` Guenter Roeck
2013-03-23 15:15 ` mfd: Core driver for W836{2389}7[T]HF Guenter Roeck
2013-03-23 17:49 ` mfd: Core driver for Winbond chips Guenter Roeck
2013-03-24 2:39 ` Guenter Roeck
2013-04-09 9:37 ` Samuel Ortiz
2013-04-09 11:36 ` Guenter Roeck
2013-04-09 11:45 ` Wim Van Sebroeck
2013-04-09 16:18 ` Guenter Roeck
2013-04-09 17:31 ` Wim Van Sebroeck
2013-04-10 0:36 ` Guenter Roeck
2013-04-10 20:59 ` Wim Van Sebroeck
2013-04-29 15:00 ` Guenter Roeck
2013-04-09 11:37 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322205258.GE7867@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=P@draigBrady.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®