From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757612Ab3CYM6E (ORCPT ); Mon, 25 Mar 2013 08:58:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:17954 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757383Ab3CYM6B (ORCPT ); Mon, 25 Mar 2013 08:58:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,905,1355126400"; d="scan'208";a="308010326" Date: Mon, 25 Mar 2013 14:57:57 +0200 From: Heikki Krogerus To: Arnd Bergmann Cc: Greg Kroah-Hartman , Ley Foon Tan , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property Message-ID: <20130325125757.GA2847@xps8300> References: <1364211286-31611-1-git-send-email-heikki.krogerus@linux.intel.com> <201303251140.31866.arnd@arndb.de> <20130325122851.GB20052@xps8300> <201303251247.58823.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201303251247.58823.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2013 at 12:47:58PM +0000, Arnd Bergmann wrote: > On Monday 25 March 2013, Heikki Krogerus wrote: > > On Mon, Mar 25, 2013 at 11:40:31AM +0000, Arnd Bergmann wrote: > > > On Monday 25 March 2013, Heikki Krogerus wrote: > > > > This will add support for hardware flow control. It is > > > > limited to be used only with 8250 driver. > > > > > > > > Signed-off-by: Heikki Krogerus > > > > > > Does this imply that we can use hardware flow control only when this > > > flag is set in the device tree? I assumed that working flow control > > > would be the default. Is it not? > > > > OK, the commit message is wrong. Is the patch otherwise OK? > > I still find the text in the binding and the name of the property confusing, > because it seems to imply that you have no hardware flow control without this. > I think what you mean here is really "automatic flow control" rather than > "hardware flow control". Ah, I understand. I'll change the property name to auto-flow-control. -- heikki