From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dave Airlie <airlied@gmail.com>
Cc: "Mantas Mikulėnas" <grawity@gmail.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Matthew Garrett" <mjg@redhat.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Seth Forshee" <seth.forshee@canonical.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Ben Skeggs" <skeggsb@gmail.com>
Subject: Re: Regression: Screen turns off when booting in EFI mode
Date: Mon, 25 Mar 2013 23:55:25 +0000 [thread overview]
Message-ID: <20130325235525.GA3423@srcf.ucam.org> (raw)
In-Reply-To: <CAPM=9tyYMSsK_2eCNRTx5EsgAQtnvmHxhgPHP3GHPxKUn+wo5w@mail.gmail.com>
On Tue, Mar 26, 2013 at 09:52:14AM +1000, Dave Airlie wrote:
> >>> Because it's the only way to get the PCI ROM in some cases, like on
> >>> pretty much all Apples with Radeons. Only using it if we have no other
> >>> options probably makes sense, though. Something like this (entirely
> >>> untested)?
> >>
> >> This looks reasonable. Mantas?
> >
> > It compiles, boots, and even makes the graphics card work again.
> > So it looks good to me.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=927451
>
> popped up sounds like a regression caused by this.
Sigh. I guess we need to figure out where it thinks it's getting that
image from. The alternative is basically to go back to what Linus
suggested, remove this from pci_map_rom() and add an explicit lookup to
the video drivers.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-03-25 23:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 23:09 Mantas Mikulėnas
2013-02-21 23:54 ` Dave Airlie
2013-02-22 1:03 ` Mantas Mikulėnas
2013-03-09 21:42 ` Mantas Mikulėnas
2013-03-19 17:09 ` Linus Torvalds
2013-03-19 17:58 ` Linus Torvalds
2013-03-19 19:31 ` Mantas Mikulėnas
2013-03-19 19:59 ` Matthew Garrett
2013-03-19 20:20 ` Linus Torvalds
2013-03-19 21:16 ` Mantas Mikulėnas
2013-03-19 21:26 ` [PATCH] PCI: Use ROM images from firmware only if no other ROM source available Matthew Garrett
2013-03-25 23:52 ` Regression: Screen turns off when booting in EFI mode Dave Airlie
2013-03-25 23:55 ` Matthew Garrett [this message]
2013-03-27 19:29 ` Bjorn Helgaas
2013-03-27 20:02 ` Dave Airlie
2013-03-27 20:28 ` Bjorn Helgaas
2013-03-26 21:25 ` [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images Matthew Garrett
2013-03-26 21:25 ` [PATCH 2/3] nouveau: Attempt to use platform-provided ROM image Matthew Garrett
2013-03-26 21:25 ` [PATCH 3/3] radeon: " Matthew Garrett
2013-03-26 22:53 ` [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images Bjorn Helgaas
2013-03-26 22:55 ` Matthew Garrett
2013-03-27 20:33 ` Bjorn Helgaas
2013-03-27 20:34 ` Bjorn Helgaas
2013-03-28 8:48 ` Mantas Mikulėnas
2013-04-01 17:39 ` Bjorn Helgaas
2013-04-01 17:47 ` Matthew Garrett
2013-04-02 20:10 ` Bjorn Helgaas
2013-04-05 20:31 ` Chris Murphy
2013-04-05 20:35 ` Bjorn Helgaas
2013-04-05 22:28 ` Chris Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325235525.GA3423@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=grawity@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=seth.forshee@canonical.com \
--cc=skeggsb@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome