From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934126Ab3CZIzA (ORCPT ); Tue, 26 Mar 2013 04:55:00 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:35967 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932175Ab3CZIy6 (ORCPT ); Tue, 26 Mar 2013 04:54:58 -0400 Date: Tue, 26 Mar 2013 09:54:54 +0100 From: Sascha Hauer To: Christian Gmeiner Cc: LKML , x86@kernel.org, linux-i2c@vger.kernel.org, linux-watchdog@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 1/3] x86: Add basic support for the Congatec CGEB BIOS interface Message-ID: <20130326085454.GK1906@pengutronix.de> References: <1360663374-30951-1-git-send-email-s.hauer@pengutronix.de> <1360663374-30951-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:41 up 276 days, 1 min, 58 users, load average: 8.98, 12.61, 13.81 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2013 at 09:31:35AM +0100, Christian Gmeiner wrote: > Hi Sascha > > > > +struct cgeb_pdata { > > + struct cgeb_board_data *board; > > + int unit; > > +}; > > + > > +#endif /* __CONGATEC_CGEB_H */ > > diff --git a/arch/x86/platform/Makefile b/arch/x86/platform/Makefile > > index 8d87439..9de1789 100644 > > --- a/arch/x86/platform/Makefile > > +++ b/arch/x86/platform/Makefile > > @@ -1,5 +1,6 @@ > > # Platform specific code goes here > > obj-y += ce4100/ > > +obj-y += congatec/ > > obj-y += efi/ > > obj-y += geode/ > > obj-y += iris/ > > > Fails to build Ups, sorry. It seems I forgot to git add arch/x86/platform/congatec/Makefile. It should look like this: obj-$(CONFIG_CONGATEC_CGEB) += congatec-cgeb.o I will include this next time. Any other comments to this series? Is the base cgeb support ok to include? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |