From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630Ab3CZVFY (ORCPT ); Tue, 26 Mar 2013 17:05:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51708 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212Ab3CZVFW (ORCPT ); Tue, 26 Mar 2013 17:05:22 -0400 Date: Tue, 26 Mar 2013 14:05:20 -0700 From: Andrew Morton To: David Howells Cc: torvalds@linux-foundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] UAPI: Remove empty Kbuild files Message-Id: <20130326140520.3100447ee78322d52e6be7af@linux-foundation.org> In-Reply-To: <29647.1364331583@warthog.procyon.org.uk> References: <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> <20130326174853.10144.36253.stgit@warthog.procyon.org.uk> <29647.1364331583@warthog.procyon.org.uk> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2013 20:59:43 +0000 David Howells wrote: > Andrew Morton wrote: > > > > Remove empty Kbuild files as they cause problems with the patch program > > > which removes files that become empty. > > > > > > Should I also remove include/Kbuild as that now does nothing? Or should > > > it be left as an anchor just in case we want it in future? > > > > I think that if the build system created it, a `make clean' or `make > > mproper' should rub it out again. Ideally a `make mrproper' will give > > you a tree which is identical to a freshly-untarred kernel.org tarball > > (yes?). > > Ummm... What's that got to do with it? include/Kbuild is part of the > sources: make clean/mrproper/distclean should not be removing it. Obviously, I thought you were referring to build-time operations. > > Which reminds me of my email which you're still hiding from ;) > > Shouldn't a `make mrproper' undo the effects of `make headers_install' > > by wiping ./usr/include/? > > Ummm... > > warthog>cp .../.config . > warthog>make -j12 >&/dev/null > warthog>find usr/include/ | wc -l > 873 > warthog>make distclean >&/dev/null > warthog>find usr/include/ | wc -l > find: `usr/include/': No such file or directory > 0 > > and: > > warthog>cp .../.config . > warthog>make -j12 >&/dev/null > warthog>find usr/include/ | wc -l > 873 > warthog>make mrproper >&/dev/null > warthog>find usr/include/ | wc -l > find: `usr/include/': No such file or directory > 0 > > so I don't see the problem. Well damn. I tested this a few days ago and a `make mrproper' didn't remove usr/include. Did something change recently? If not, something odd is going on. I definitely tested it.