From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965568Ab3CZQUE (ORCPT ); Tue, 26 Mar 2013 12:20:04 -0400 Received: from co9ehsobe001.messaging.microsoft.com ([207.46.163.24]:49033 "EHLO co9outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934728Ab3CZPVn (ORCPT ); Tue, 26 Mar 2013 11:21:43 -0400 X-Forefront-Antispam-Report: CIP:163.181.249.108;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp01.amd.com;RD:none;EFVD:NLI X-SpamScore: -4 X-BigFish: VPS-4(zz98dI9371I1432I4015Izz1f42h1ee6h1de0h1202h1e76h1d1ah1d2ahzz17326ah8275dhz2dh668h839h944hd25hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1155h) X-WSS-ID: 0MK9XB1-01-G9F-02 X-M-MSG: Date: Tue, 26 Mar 2013 10:20:59 -0500 From: Jacob Shin To: "Rafael J. Wysocki" CC: Viresh Kumar , , , , , , , , Subject: Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors Message-ID: <20130326152059.GA1698@jshin-Toonie> References: <0823a96fea2d8284b7d83cee390dd5973fdaaa94.1362381470.git.viresh.kumar@linaro.org> <2565053.YP0dCLmaW9@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2565053.YP0dCLmaW9@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2013 at 12:44:40AM +0100, Rafael J. Wysocki wrote: > On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote: > > On 4 March 2013 13:07, Viresh Kumar wrote: > > > Currently, there can't be multiple instances of single governor_type. If we have > > > a multi-package system, where we have multiple instances of struct policy (per > > > package), we can't have multiple instances of same governor. i.e. We can't have > > > multiple instances of ondemand governor for multiple packages. > > > > > > Governors directory in sysfs is created at /sys/devices/system/cpu/cpufreq/ > > > governor-name/. Which again reflects that there can be only one instance of a > > > governor_type in the system. > > > > > > This is a bottleneck for multicluster system, where we want different packages > > > to use same governor type, but with different tunables. > > > > > > This patch uses the infrastructure provided by earlier patch and implements > > > init/exit routines for ondemand and conservative governors. > > > > > > Signed-off-by: Viresh Kumar > > > > As discussed in other patch thread, i dropped "cpufreq: Add Kconfig option > > to enable/disable have_multiple_policies" patch and following is the fixup > > to this patch: > > > > I have queued all patches i had for 3.10 here: > > > > http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-3.10 > > OK, applied these to linux-pm.git/bleeding-edge. Hi, latest bleeding-edge is spewing this out on boot: [ 3.585157] ------------[ cut here ]------------ [ 3.592227] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xc8/0x100() [ 3.599521] Hardware name: Dinar [ 3.606878] sysfs: cannot create duplicate filename '/devices/system/cpu/cpufreq/ondemand' [ 3.614634] Modules linked in: [ 3.622382] Pid: 1, comm: swapper/0 Not tainted 3.9.0-rc4+ #7 [ 3.630305] Call Trace: [ 3.638251] [] warn_slowpath_common+0x7f/0xc0 [ 3.646435] [] warn_slowpath_fmt+0x46/0x50 [ 3.654586] [] ? strlcat+0x60/0x80 [ 3.662765] [] sysfs_add_one+0xc8/0x100 [ 3.670977] [] create_dir+0x7c/0xd0 [ 3.679239] [] sysfs_create_subdir+0x1f/0x30 [ 3.687601] [] internal_create_group+0x64/0x210 [ 3.696098] [] sysfs_create_group+0x13/0x20 [ 3.704700] [] cpufreq_governor_dbs+0x400/0x590 [ 3.713401] [] od_cpufreq_governor_dbs+0x17/0x20 [ 3.722191] [] __cpufreq_governor+0x47/0xc0 [ 3.731071] [] __cpufreq_set_policy+0x19d/0x1b0 [ 3.739968] [] cpufreq_add_dev_interface+0x259/0x2b0 [ 3.748960] [] ? acpi_processor_get_performance_info+0x21c/0x452 [ 3.758099] [] ? cpufreq_update_policy+0x130/0x130 [ 3.767366] [] cpufreq_add_dev+0x3b0/0x4d0 [ 3.776659] [] ? cpufreq_gov_dbs_init+0x12/0x12 [ 3.785985] [] subsys_interface_register+0x89/0xd0 [ 3.795452] [] cpufreq_register_driver+0x8e/0x180 [ 3.804919] [] acpi_cpufreq_init+0xf6/0x1f8 [ 3.814360] [] ? set_trace_device+0x80/0x80 [ 3.823558] [] do_one_initcall+0x3f/0x170 [ 3.832476] [] kernel_init_freeable+0x13e/0x1cd [ 3.841131] [] ? do_early_param+0x86/0x86 [ 3.849506] [] ? rest_init+0x80/0x80 [ 3.857557] [] kernel_init+0xe/0xf0 [ 3.865260] [] ret_from_fork+0x7c/0xb0 [ 3.872886] [] ? rest_init+0x80/0x80 [ 3.880456] ---[ end trace 1a5c6247c6d9b0ac ]--- [ 3.888201] ------------[ cut here ]------------ This warning is repeated for number of cpus - 1 times. And when I do: $ cat /sys/devices/system/cpu/cpufreq/ondemand/up_threshold [ 489.103388] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 [ 489.112064] IP: [] show_up_threshold+0x1c/0x30 [ 489.120511] PGD a285e6067 PUD a27085067 PMD 0 [ 489.128690] Oops: 0000 [#1] SMP [ 489.136521] Modules linked in: [ 489.144134] CPU 15 [ 489.144229] Pid: 1565, comm: cat Tainted: G W 3.9.0-rc4+ #7 AMD Dinar/Dinar [ 489.159654] RIP: 0010:[] [] show_up_threshold+0x1c/0x30 [ 489.167864] RSP: 0018:ffff880423859e88 EFLAGS: 00010246 [ 489.176043] RAX: 0000000000000000 RBX: ffff880a271188c0 RCX: ffffffff81a41810 [ 489.184372] RDX: 0000000000000000 RSI: ffffffff81e02dae RDI: ffffffff820d7860 [ 489.184373] RBP: ffff880423859e88 R08: ffffea0028b6df80 R09: 00000000001f05b8 [ 489.184374] R10: 0000000000001b97 R11: 0000000000000246 R12: ffff880423859f50 [ 489.184374] R13: 0000000000008000 R14: ffff880a271188a0 R15: ffff8804251aa070 [ 489.184377] FS: 00007f3278b31700(0000) GS:ffff880a2fcc0000(0000) knlGS:0000000000000000 [ 489.184378] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 489.184378] CR2: 0000000000000010 CR3: 0000000a2db82000 CR4: 00000000000407e0 [ 489.184380] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 489.184381] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 489.184382] Process cat (pid: 1565, threadinfo ffff880423858000, task ffff880424805c00) [ 489.184382] Stack: [ 489.184389] ffff880423859e98 ffffffff8133814f ffff880423859ef8 ffffffff811fd62a [ 489.184394] 000000002bf67be2 ffff8808260b7a80 ffffffff81a41810 00000000012c8000 [ 489.184399] ffff880423859ef8 0000000000008000 00000000012c8000 ffff880423859f50 [ 489.184400] Call Trace: [ 489.184406] [] kobj_attr_show+0xf/0x30 [ 489.184411] [] sysfs_read_file+0xaa/0x190 [ 489.184415] [] vfs_read+0xb0/0x180 [ 489.184418] [] sys_read+0x52/0xa0 [ 489.184422] [] ? do_page_fault+0xe/0x10 [ 489.184426] [] system_call_fastpath+0x16/0x1b [ 489.184441] Code: 52 08 e8 78 2c c8 ff 5d 48 98 c3 0f 1f 40 00 66 66 66 66 90 55 48 8b 57 70 48 89 f0 48 89 c7 48 c7 c6 ae 2d e0 81 31 c0 48 89 e5 <48> 8b 52 10 8b 52 0c e8 48 2c c8 ff 5d 48 98 c3 0f 1f 40 00 66 [ 489.184443] RIP [] show_up_threshold+0x1c/0x30 [ 489.184443] RSP [ 489.184444] CR2: 0000000000000010 [ 489.184507] ---[ end trace 1a5c6247c6d9b0c3 ]--- Any ideas? Thanks,