From: Guenter Roeck <linux@roeck-us.net>
To: Hongbo Zhang <hongbo.zhang@linaro.org>
Cc: khali@linux-fr.org, lm-sensors@lm-sensors.org, cbou@mail.ru,
dwmw2@infradead.org, linaro-kernel@lists.linaro.org,
STEricsson_nomadik_linux@list.st.com, linus.walleij@linaro.org,
lee.jones@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver
Date: Tue, 26 Mar 2013 08:23:10 -0700 [thread overview]
Message-ID: <20130326152310.GA9153@roeck-us.net> (raw)
In-Reply-To: <1364281619-13208-6-git-send-email-hongbo.zhang@linaro.org>
On Tue, Mar 26, 2013 at 03:06:59PM +0800, Hongbo Zhang wrote:
> Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500
> chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for
> all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed
> structure, other chip specific files can be added simply using the same common
> layer abx500.c.
>
> Signed-off-by: Hongbo Zhang <hongbo.zhang@linaro.org>
Looks good except ...
> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> index d9f1f25..05a1077 100644
> --- a/drivers/power/ab8500_bmdata.c
> +++ b/drivers/power/ab8500_bmdata.c
> @@ -28,8 +28,10 @@ const struct abx500_res_to_temp ab8500_temp_tbl_a_thermistor[] = {
> {60, 13437},
> {65, 12500},
> };
> +EXPORT_SYMBOL(ab8500_temp_tbl_a_thermistor);
>
Those exports should be in the previous patch where you start exporting the symbols,
not in this patch.
Thanks,
Guenter
next prev parent reply other threads:[~2013-03-26 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 7:06 [PATCH v6 0/5] Add ST-Ericsson AB8500 HWMON driver Hongbo Zhang
2013-03-26 7:06 ` [PATCH v6 1/5] ab8500_btemp: make ab8500_btemp_get* interfaces public Hongbo Zhang
2013-03-26 7:06 ` [PATCH v6 2/5] ab8500: power: eliminate CamelCase warning of some variables Hongbo Zhang
2013-03-26 7:06 ` [PATCH v6 3/5] ab8500: power: add const attributes to some data arrays Hongbo Zhang
2013-03-26 7:06 ` [PATCH v6 4/5] ab8500: power: export abx500_res_to_temp tables for hwmon Hongbo Zhang
2013-03-26 7:06 ` [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver Hongbo Zhang
2013-03-26 15:23 ` Guenter Roeck [this message]
2013-03-27 2:13 ` Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326152310.GA9153@roeck-us.net \
--to=linux@roeck-us.net \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=hongbo.zhang@linaro.org \
--cc=khali@linux-fr.org \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®