From: Michal Marek <mmarek@suse.cz>
To: Kirill Tkhai <tkhai@yandex.ru>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/tags.sh: Add magic for OFFSET and DEFINE
Date: Tue, 26 Mar 2013 22:35:32 +0100 [thread overview]
Message-ID: <20130326213532.GB22359@pobox.suse.cz> (raw)
In-Reply-To: <1810321364036300@web2f.yandex.ru>
On Sat, Mar 23, 2013 at 02:58:20PM +0400, Kirill Tkhai wrote:
> Add rules for definitions which is generally used in asm-offsets files.
>
> Signed-off-by: Kirill V Tkhai <tkhai@yandex.ru>
> CC: Michal Marek <mmarek@suse.cz>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
> scripts/tags.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 26a87e6..74f02e4 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -199,7 +199,9 @@ exuberant()
> --regex-c='/DEFINE_PER_CPU_SHARED_ALIGNED\(([^,]*,\s*)(\w*).*\)/\2/v/' \
> --regex-c='/DECLARE_WAIT_QUEUE_HEAD\((\w*)/\1/v/' \
> --regex-c='/DECLARE_(TASKLET|WORK|DELAYED_WORK)\((\w*)/\2/v/' \
> - --regex-c='/DEFINE_PCI_DEVICE_TABLE\((\w*)/\1/v/'
> + --regex-c='/DEFINE_PCI_DEVICE_TABLE\((\w*)/\1/v/' \
> + --regex-c='/(^\s)OFFSET\((\w*)/\2/v/' \
> + --regex-c='/(^\s)DEFINE\((\w*)/\2/v/'
The macro definitions in the asm-offsets.h file are ammended with a
comment explaining what the value actually means. So you see both the
value and the semantic of the macro:
#define TI_flags 16 /* offsetof(struct thread_info, flags) # */
By jumping to the asm-offset.c file instead, you would get only a subset
of that information.
OFFSET(TI_flags, thread_info, flags);
Unless I'm missing something, I don't think that this patch improves
much.
Michal
next prev parent reply other threads:[~2013-03-26 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 10:58 Kirill Tkhai
2013-03-26 21:35 ` Michal Marek [this message]
2013-03-27 11:59 ` Kirill Tkhai
2013-03-27 13:29 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326213532.GB22359@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®