From: Wolfram Sang <wsa@the-dreams.de>
To: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
nsekhar@ti.com, khilman@deeprootsystems.com, ben-linux@fluff.org,
w.sang@pengutronix.de
Subject: Re: [PATCH V4] i2c: davinci: update to devm_* API
Date: Fri, 29 Mar 2013 12:17:09 +0100 [thread overview]
Message-ID: <20130329111709.GA6359@the-dreams.de> (raw)
In-Reply-To: <1362483885-16561-1-git-send-email-manishv.b@ti.com>
On Tue, Mar 05, 2013 at 05:14:45PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> Update the code to use devm_* API so that driver
> core will manage resources.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
Applied the following fix:
> + dev->base = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(dev->base)) {
> + r = PTR_ERR(dev->base);
> + dev_err(&pdev->dev, "I2C region already claimed\n");
> + goto err_unuse_clocks;
No dev_err after devm_ioremap_resource. make coccicheck will tell you
about this.
Otherwise: Applied to for-next, thanks!
prev parent reply other threads:[~2013-03-29 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 11:44 Vishwanathrao Badarkhe, Manish
2013-03-15 11:23 ` Vishwanathrao Badarkhe, Manish
2013-03-29 11:17 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329111709.GA6359@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=ben-linux@fluff.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishv.b@ti.com \
--cc=nsekhar@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®