From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ning Jiang <ning.n.jiang@gmail.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
kgene.kim@samsung.com, davidb@codeaurora.org, dwalker@fifo99.com,
bryanh@codeaurora.org, john.stultz@linaro.org,
tglx@linutronix.de, linus.walleij@linaro.org,
shawn.guo@linaro.org, rob.herring@calxeda.com, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ARM: timer: Shutdown clock event device when stopping local timer
Date: Sat, 30 Mar 2013 10:04:08 +0000 [thread overview]
Message-ID: <20130330100408.GA17995@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAH3Oq6QA0DCEDc-Yh+k=3bgUH7xzKxHSC1aWSoL4NzaYCZZHbg@mail.gmail.com>
On Sat, Mar 30, 2013 at 05:57:38PM +0800, Ning Jiang wrote:
> 2013/3/30 Stephen Boyd <sboyd@codeaurora.org>:
> > On 03/29/13 02:24, ning.n.jiang@gmail.com wrote:
> >> From: Ning Jiang <ning.n.jiang@gmail.com>
> >>
> >> Currently there are two problems when we try to stop local timer.
> >> First, it calls set_mode function directly so mode state is not
> >> updated for the clock event device. Second, it makes the device
> >> unused instead of shutdown.
> >
> > What device is this a problem on? I believe this only matters to drivers
> > which enable their timer in their set_next_event() callback? But even
> > then, does anything actually happen because the interrupt should have
> > been disabled in the local timer stop callback.
> >
>
> Right. Drivers which enable timer in set_next_event() will have this problem.
> It will not have functional problem in my case. But my device cannot enter
> low power mode with a pending interrupt even if it is disabled.
You're not telling us what you have discovered. How does set_next_event()
get called after we've set the mode to UNUSED in the current code?
next prev parent reply other threads:[~2013-03-30 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 9:24 ning.n.jiang
2013-03-29 18:32 ` Stephen Boyd
2013-03-30 9:57 ` Ning Jiang
2013-03-30 10:04 ` Russell King - ARM Linux [this message]
2013-03-30 11:56 ` Ning Jiang
2013-03-31 13:11 ` Ning Jiang
2013-03-31 23:41 ` Daniel Lezcano
2013-04-01 1:56 ` Ning Jiang
2013-04-02 12:01 ` Ning Jiang
2013-04-01 0:06 ` Daniel Lezcano
2013-04-01 2:05 ` Ning Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330100408.GA17995@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=john.stultz@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ning.n.jiang@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®