From: Jean Delvare <khali@linux-fr.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Wolfram Sang <wsa@the-dreams.de>, Ben Dooks <ben-linux@fluff.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] i2c: Remove detach_adapter
Date: Sat, 30 Mar 2013 15:52:01 +0100 [thread overview]
Message-ID: <20130330155201.1e145ed6@endymion.delvare> (raw)
In-Reply-To: <1362853009-20789-2-git-send-email-lars@metafoo.de>
Hi Lars,
On Sat, 9 Mar 2013 19:16:44 +0100, Lars-Peter Clausen wrote:
> The detach_adapter callback has been deprecated for quite some time and has no
> user left. Keeping it alive blocks other cleanups, so remove it.
I'm all for it. Originally I intended to remove both attach_adapter and
detach_adapter at the same time, unfortunately there are still users of
attach_adapter around, despite it being deprecated for 2 or 3 years
now. So the patch removing them is still sitting on my disk. Getting
rid of at least detach_adapter now is a good idea.
One minor comment:
> @@ -1088,11 +1077,9 @@ int i2c_del_adapter(struct i2c_adapter *adap)
>
> /* Tell drivers about this removal */
> mutex_lock(&core_lock);
> - res = bus_for_each_drv(&i2c_bus_type, NULL, adap,
> + bus_for_each_drv(&i2c_bus_type, NULL, adap,
> __process_removed_adapter);
This would fit on a single line now.
Reviewed-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
next prev parent reply other threads:[~2013-03-30 14:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 18:16 [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void Lars-Peter Clausen
2013-03-09 18:16 ` [PATCH 1/6] i2c: Remove detach_adapter Lars-Peter Clausen
2013-03-30 14:52 ` Jean Delvare [this message]
2013-03-09 18:16 ` [PATCH 2/6] i2c: i2c_del_adapter: Don't treat removing a non-registered adapter as error Lars-Peter Clausen
2013-03-30 18:17 ` Jean Delvare
2013-03-09 18:16 ` [PATCH 3/6] i2c: Ignore return value of i2c_del_adapter() Lars-Peter Clausen
2013-03-11 17:52 ` Ben Hutchings
2013-03-30 6:34 ` Wolfram Sang
2013-03-30 7:55 ` Jean Delvare
2013-03-30 8:11 ` Lars-Peter Clausen
2013-03-30 8:43 ` Jean Delvare
2013-03-31 8:25 ` Jean Delvare
2013-03-31 13:12 ` Shawn Guo
2013-03-09 18:16 ` [PATCH 4/6] i2c: Make return type of i2c_del_adapter() void Lars-Peter Clausen
2013-03-31 9:04 ` Jean Delvare
2013-03-09 18:16 ` [PATCH 5/6] i2c: Ignore the return value of i2c_del_mux_adapter() Lars-Peter Clausen
2013-03-13 6:05 ` [5/6] " Guenter Roeck
2013-03-31 9:23 ` [PATCH 5/6] " Jean Delvare
2013-03-09 18:16 ` [PATCH 6/6] i2c: Make the return type of i2c_del_mux_adapter() void Lars-Peter Clausen
2013-03-31 9:24 ` Jean Delvare
2013-03-30 6:33 ` [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void Wolfram Sang
2013-03-30 20:13 ` Jean Delvare
2013-03-30 20:43 ` Lars-Peter Clausen
2013-03-31 7:56 ` Jean Delvare
2013-03-31 11:30 ` Jean Delvare
2013-04-02 5:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330155201.1e145ed6@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux@fluff.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®