From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760219Ab3DBExA (ORCPT ); Tue, 2 Apr 2013 00:53:00 -0400 Received: from sauhun.de ([89.238.76.85]:32873 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759828Ab3DBEw6 (ORCPT ); Tue, 2 Apr 2013 00:52:58 -0400 Date: Tue, 2 Apr 2013 06:52:37 +0200 From: Wolfram Sang To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , Mika Westerberg , linux-i2c@vger.kernel.org, Ben Dooks , Jean Delvare Subject: Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices() Message-ID: <20130402045105.GA17682@the-dreams.de> References: <2966020.zlpeyGGUDW@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2966020.zlpeyGGUDW@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 01, 2013 at 02:25:03AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The ACPI handle of struct i2c_adapter's dev member should not be > set, because this causes that struct i2c_adapter to be associated > with the ACPI device node corresponding to its parent as the > second "physical_device", which is incorrect (this happens during > the registration of struct i2c_adapter). Consequently, > acpi_i2c_register_devices() should use the ACPI handle of the > parent of the struct i2c_adapter it is called for rather than the > struct i2c_adapter's ACPI handle (which should be NULL). > > Make that happen and modify the i2c-designware-platdrv driver, > which currently is the only driver for ACPI-enumerated I2C > controller chips, not to set the ACPI handle for the > struct i2c_adapter it creates. > > Signed-off-by: Rafael J. Wysocki Shall this go via the I2C tree? If not, for the I2C part: Acked-by: Wolfram Sang