From: Felipe Balbi <balbi@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@ti.com>,
Thomas Winischhofer <thomas@winischhofer.net>,
Florian Fainelli <florian@openwrt.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block
Date: Thu, 4 Apr 2013 21:02:30 +0300 [thread overview]
Message-ID: <20130404180229.GA5926@arwen.pp.htv.fi> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1304041339530.1324-100000@iolanthe.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
Hi,
On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> > > index 30ea7ca..0d03a52 100644
> > > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > > @@ -1,7 +1,7 @@
> > >
> > > config USB_SISUSBVGA
> > > tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> > > - depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> > > + depends on (USB_MUSB_HDRC || USB_EHCI_HCD)
> >
> > is it just me or would everybody agree that depending on MUSB or EHCI
> > here is wrong ?
>
> That line certainly looks like it could be removed entirely. Perhaps
> the original author can enlighten us.
>
> In any case, it's not relevant to the purpose of this patch set.
right :-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-04 18:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 15:57 [PATCH 0/5 v3] USB: Kconfig cleanups Florian Fainelli
2013-04-04 15:57 ` [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-04 17:14 ` Felipe Balbi
2013-04-04 17:42 ` Alan Stern
2013-04-04 18:02 ` Felipe Balbi [this message]
2013-04-04 19:42 ` Arnd Bergmann
2013-04-06 9:51 ` Thomas Winischhofer
2013-04-04 15:57 ` [PATCH 2/5 v3] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-04 15:57 ` [PATCH 3/5 v3] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-04 15:57 ` [PATCH 4/5 v3] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-04 15:57 ` [PATCH 5/5 v3] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-04 17:02 ` [PATCH 0/5 v3] USB: Kconfig cleanups Alan Stern
2013-04-08 16:32 ` Greg KH
2013-04-08 18:16 ` Florian Fainelli
2013-04-08 18:23 ` Greg KH
2013-04-09 12:29 ` [PATCH 0/5 v4] " Florian Fainelli
2013-04-09 12:29 ` [PATCH 1/5 v4] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-23 11:20 ` Felipe Balbi
2013-04-09 12:29 ` [PATCH 2/5 v4] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-09 12:29 ` [PATCH 3/5 v4] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-09 12:29 ` [PATCH 4/5 v4] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-09 12:29 ` [PATCH 5/5 v4] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404180229.GA5926@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=arnd@arndb.de \
--cc=florian@openwrt.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®