From: Al Viro <viro@ZenIV.linux.org.uk>
To: Daniel Cotey <puff65537@bansheeslibrary.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: [RFC] drivers/staging/silicom/bp_proc.c removal
Date: Thu, 4 Apr 2013 20:12:45 +0100 [thread overview]
Message-ID: <20130404191245.GT21522@ZenIV.linux.org.uk> (raw)
It's all ifdefed out (on BYPASS_SUPPORT), severely bitrotten (try
to remove the ifdef and watch what happens on attempt to build) and, AFAICS,
it's a duplicate of the stuff in bp_mod.c.
Is there any reason to keep it around? IOW, how about
git rm drivers/staging/silicom/bp_proc.c
git mv drivers/staging/silicom/bp{,ctl}_mod.c
ed drivers/staging/silicom/Makefile <<EOF
/bp_proc/d
wq
EOF
and if anybody needs to see what used to be there, git history is enough...
Another thing: please, check the vfs.git patches to bp_mod.c
in linux-next. I think they are safe, but I don't have the hardware
to test them on...
next reply other threads:[~2013-04-04 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 19:12 Al Viro [this message]
[not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>
2013-04-05 17:37 ` Greg Kroah-Hartman
2013-04-05 17:48 ` Al Viro
2013-04-05 22:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404191245.GT21522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puff65537@bansheeslibrary.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome