From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH] regulator: core: don't require a supply when supply_name is specified
Date: Fri, 5 Apr 2013 10:54:57 +0100 [thread overview]
Message-ID: <20130405095457.GB6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365114467-16357-1-git-send-email-abrestic@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Thu, Apr 04, 2013 at 03:27:47PM -0700, Andrew Bresticker wrote:
> Regulator drivers may specify regulator_desc->supply_name which
> regulator_register() will use to find the supply node for a regulator.
> If no supply was specified in the device tree or the supply has yet
> to be registered regulator_register() will fail, deferring the probe
> of the regulator. In the case where no supply node was specified in the
> device tree, there is no supply and it is pointless to try and find one
> later, so go ahead and add the regulator without the supply.
I'd call this a broken device tree to be honest, the regulators ought to
have a supply specified. We should complain about it. We probably
ought to be doing this though so I'll apply.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-04-05 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:27 Andrew Bresticker
2013-04-05 9:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405095457.GB6597@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=abrestic@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome