From: Samuel Ortiz <sameo@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MFD: rtsx_pcr, fix probe fail path
Date: Fri, 5 Apr 2013 18:41:23 +0200 [thread overview]
Message-ID: <20130405164123.GQ17363@zurbaran> (raw)
In-Reply-To: <1365104051-22872-1-git-send-email-jslaby@suse.cz>
Hi Jiry,
On Thu, Apr 04, 2013 at 09:34:11PM +0200, Jiri Slaby wrote:
> When rtsx_pci_acquire_irq fails in rtsx_pci_probe, we forget to
> disable an MSI (if we enabled it). This results in this warning on the
> next attempt to load the module:
> WARNING: at drivers/pci/msi.c:834 pci_enable_msi_block+0x2a4/0x2b0()
> Hardware name: HP EliteBook 840 G1
> Modules linked in: rtsx_pci(+) ...
> Pid: 4056, comm: modprobe Tainted: G I 3.8.0-9405-gd895cb1-1-vanilla #1
> Call Trace:
> [<ffffffff81045c6a>] warn_slowpath_common+0x7a/0xc0
> [<ffffffff81045cc5>] warn_slowpath_null+0x15/0x20
> [<ffffffff81302544>] pci_enable_msi_block+0x2a4/0x2b0
> [<ffffffffa05e335a>] rtsx_pci_probe+0x55a/0x720 [rtsx_pci]
> ...
>
> So properly disable MSI in that case.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
> drivers/mfd/rtsx_pcr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to mfd-next, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-04-05 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 19:34 Jiri Slaby
2013-04-05 16:41 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405164123.GQ17363@zurbaran \
--to=sameo@linux.intel.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®